Changeset 49445 in webkit

Timestamp:

Oct 12, 2009 11:09:13 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-12 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=30307

Fix 0 sentinel for g_object_set() function call.

• platform/graphics/gtk/DataSourceGStreamer.cpp: (webkit_data_src_uri_set_uri): 0 is passed as 32 bit value on x86-64 in vararg functions, but g_object_set() expects a 64 bit 0. This will cause crashes.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gtk/DataSourceGStreamer.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
+
+        Reviewed by Gustavo Noronha.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30307
+        
+        Fix 0 sentinel for g_object_set() function call.
+
+        * platform/graphics/gtk/DataSourceGStreamer.cpp:
+        (webkit_data_src_uri_set_uri):
+        0 is passed as 32 bit value on x86-64 in vararg functions, but
+        g_object_set() expects a 64 bit 0. This will cause crashes.
+
 2009-10-12  Cameron McCormack  <cam@mcc.id.au>
 

trunk/WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp

@@ -215 +215 @@
                                                                        decoded_size,
                                                                        g_free);
-            g_object_set(src->kid, "stream", stream, 0);
+            g_object_set(src->kid, "stream", stream, NULL);
             g_object_unref(stream);