Changeset 49675 in webkit


Ignore:
Timestamp:
Oct 16, 2009 5:47:17 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-10-16 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Added test case for testing navigator.language.
https://bugs.webkit.org/show_bug.cgi?id=29653

Different browsers may not return the exact same result.
Some examples here:
Safari 4 WinXP: "en-US"
Safari 4 Mac: "en-us"
Firefox 3 Mac/WinXP: "en-US"
Opera 9.64: "en"
Epiphany 2 GTK: "en"
Chrome 3 WinXP: "en-US"

The test case checks if the first two letters are "en"
when system locale is set to "en_US.iso88591".

  • fast/js/navigator-language-expected.txt: Added.
  • fast/js/navigator-language.html: Added.

2009-10-16 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Default language translation should be determined by locale settings,
e.g., "en-US".
https://bugs.webkit.org/show_bug.cgi?id=29653

Test: fast/js/navigator-language.html

  • platform/qt/Localizations.cpp: (WebCore::defaultLanguage):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r49668 r49675  
     12009-10-16  Shu Chang  <Chang.Shu@nokia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Added test case for testing navigator.language.
     6        https://bugs.webkit.org/show_bug.cgi?id=29653
     7 
     8        Different browsers may not return the exact same result.
     9        Some examples here:
     10        Safari 4 WinXP: "en-US"
     11        Safari 4 Mac: "en-us"
     12        Firefox 3 Mac/WinXP: "en-US"
     13        Opera 9.64: "en"
     14        Epiphany 2 GTK: "en"
     15        Chrome 3 WinXP: "en-US"
     16
     17        The test case checks if the first two letters are "en"
     18        when system locale is set to "en_US.iso88591".
     19
     20        * fast/js/navigator-language-expected.txt: Added.
     21        * fast/js/navigator-language.html: Added.
     22
    1232009-10-15  Daniel Bates  <dbates@webkit.org>
    224
  • trunk/WebCore/ChangeLog

    r49674 r49675  
     12009-10-16  Shu Chang  <Chang.Shu@nokia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Default language translation should be determined by locale settings,
     6        e.g., "en-US".
     7        https://bugs.webkit.org/show_bug.cgi?id=29653
     8
     9        Test: fast/js/navigator-language.html
     10
     11        * platform/qt/Localizations.cpp:
     12        (WebCore::defaultLanguage):
     13
    1142009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    215
  • trunk/WebCore/platform/qt/Localizations.cpp

    r48876 r49675  
    3434
    3535#include <QCoreApplication>
     36#include <QLocale>
    3637
    3738namespace WebCore {
     
    5455String defaultLanguage()
    5556{
    56     return "en";
     57    QLocale locale;
     58    return locale.name().replace("_", "-");
    5759}
    5860
Note: See TracChangeset for help on using the changeset viewer.