Changeset 49748 in webkit

Timestamp:

Oct 17, 2009 11:27:17 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Fix inefficient string concatenation.

LayoutTests/fast/css/large-list-of-rules-crash.html contains code that
concatenate strings in an inefficient way. Concatenation of strings should be
done with Array.join method. This patch fixes this issue, and also fixes typos
in the test.

fast/css/large-list-of-rules-crash.html concatenates strings in an inefficient way
​https://bugs.webkit.org/show_bug.cgi?id=30436

• fast/css/large-list-of-rules-crash.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/css/large-list-of-rules-crash.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-10-17  Yuta Kitamura  <yutak@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Fix inefficient string concatenation.
+        
+        LayoutTests/fast/css/large-list-of-rules-crash.html contains code that
+        concatenate strings in an inefficient way. Concatenation of strings should be
+        done with Array.join method. This patch fixes this issue, and also fixes typos
+        in the test.
+
+        fast/css/large-list-of-rules-crash.html concatenates strings in an inefficient way
+        https://bugs.webkit.org/show_bug.cgi?id=30436
+
+        * fast/css/large-list-of-rules-crash.html:
+
 2009-10-17  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/LayoutTests/fast/css/large-list-of-rules-crash.html

@@ -4 +4 @@
 
 <script type="text/javascript">
-var s = "";
-for (i = 0 ; i < 200000 ; i++) {
-   s += "a {}\n";
-}
+var array = Array(200000);
+for (var i = 0; i < 200000; ++i)
+    array[i] = "a {}\n";
+var s = array.join("");
+
 var style = document.createElement("style");
 style.appendChild(document.createTextNode(s));
@@ -18 +19 @@
 <!-- loading a linked style sheet causes the list of CSS Rules to be rebuilt,
      which caused a crash (stack overflow) -->
-<link rel="stylesheet" href="results/large-list-of-rules-crash.css"> 
-<link rel="stylesheet" href="results/large-list-of-rules-crash.css">
+<link rel="stylesheet" href="resources/large-list-of-rules-crash.css">
+<link rel="stylesheet" href="resources/large-list-of-rules-crash.css">
 
 <p>Test case for