Changeset 49751 in webkit


Ignore:
Timestamp:
Oct 18, 2009 9:23:15 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-10-18 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez

https://bugs.webkit.org/show_bug.cgi?id=25901
Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag

Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r49745 r49751  
     12009-10-18  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
     2
     3        Reviewed by Xan Lopez
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=25901
     6        Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag
     7
     8        Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.
     9
     10        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
     11        (webkit_accessible_get_role):
     12
    1132009-10-17  Nikolas Zimmermann  <nzimmermann@rim.com>
    214
  • trunk/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp

    r49743 r49751  
    257257    case ApplicationRole:
    258258        return ATK_ROLE_APPLICATION;
    259     //case LabelRole: // TODO: should this be covered in the switch?
    260     //    return ATK_ROLE_LABEL;
    261259    case GroupRole:
    262260    case RadioGroupRole:
     
    301299    }
    302300
    303     // WebCore does not know about paragraph role
     301    // WebCore does not know about paragraph role, label role, or section role
    304302    if (AXObject->isAccessibilityRenderObject()) {
    305303        Node* node = static_cast<AccessibilityRenderObject*>(AXObject)->renderer()->node();
    306         if (node && node->hasTagName(HTMLNames::pTag))
    307             return ATK_ROLE_PARAGRAPH;
     304        if (node) {
     305            if (node->hasTagName(HTMLNames::pTag))
     306                return ATK_ROLE_PARAGRAPH;
     307            if (node->hasTagName(HTMLNames::labelTag))
     308                return ATK_ROLE_LABEL;
     309            if (node->hasTagName(HTMLNames::divTag))
     310                return ATK_ROLE_SECTION;
     311        }
    308312    }
    309313
Note: See TracChangeset for help on using the changeset viewer.