Changeset 49758 in webkit


Ignore:
Timestamp:
Oct 18, 2009 4:17:37 PM (15 years ago)
Author:
pfeldman@chromium.org
Message:

2009-10-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Title of dir(["test", "test2"]) should be Array

​https://bugs.webkit.org/show_bug.cgi?id=30486

Test: inspector/console-tests.html

  • inspector/front-end/InjectedScript.js:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/inspector/console-tests-expected.txt

    r49737 r49758  
    1414CONSOLE MESSAGE: line 22: 1
    1515CONSOLE MESSAGE: line 23: [object HTMLDocument]
     16CONSOLE MESSAGE: line 24: test1,test2
     17CONSOLE MESSAGE: line 25: [object NodeList]
    1618Tests that console logging dumps proper messages.
    1719
    … …  
    3133console-tests.html:221 2 3 console-message console-js-source console-log-level
    3234console-tests.html:23HTMLDocument console-message console-js-source console-log-level
     35console-tests.html:24Array console-message console-js-source console-log-level
     36console-tests.html:25NodeList console-message console-js-source console-log-level
    3337

  • trunk/LayoutTests/inspector/console-tests.html

    r49737 r49758  
    2222    console.log('1', '2', '3');
    2323    console.dir(document);
     24    console.dir(["test1", "test2"]);
     25    console.dir(document.childNodes);
    2426
    2527    function callback(result)

  • trunk/WebCore/ChangeLog

    r49757 r49758  
     12009-10-18  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: Title of dir(["test", "test2"]) should be Array
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=30486
     8
     9        Test: inspector/console-tests.html
     10
     11        * inspector/front-end/InjectedScript.js:
     12
    1132009-10-18  Dirk Schulze  <krit@webkit.org>
    214

  • trunk/WebCore/inspector/front-end/InjectedScript.js

    r49557 r49758  
    11431143    case "object":
    11441144    case "node":
     1145    case "array":
    11451146        return type2;
    1146     case "array":
    1147         return "[" + obj.toString() + "]";
    11481147    case "string":
    11491148        if (!abbreviated)
Note: See TracChangeset for help on using the changeset viewer.