Changeset 49767 in webkit


Ignore:
Timestamp:
Oct 18, 2009 11:59:58 PM (15 years ago)
Author:
eric@webkit.org
Message:

2009-10-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Adam Barth.

Fixes issue where doubleclicking a word could select following adjacent newlines.
​https://bugs.webkit.org/show_bug.cgi?id=30234

  • platform/mac/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
  • platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
  • platform/mac/editing/selection/script-tests/TEMPLATE.html: Added.
  • platform/mac/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
  • platform/win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
  • platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
  • platform/win/editing/selection/script-tests/TEMPLATE.html: Added.
  • platform/win/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):

2009-10-18 Erik Arvidsson <​arv@chromium.org>

Reviewed by Adam Barth.

Fixes issue where doubleclicking a word could select following adjacent newlines.
​https://bugs.webkit.org/show_bug.cgi?id=30234

Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html

platform/mac/editing/selection/script-tests/TEMPLATE.html
platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/win/editing/selection/script-tests/TEMPLATE.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
Location:
trunk
Files:
10 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r49762 r49767  
     12009-10-18  Erik Arvidsson  <arv@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Fixes issue where doubleclicking a word could select following adjacent newlines.
     6        https://bugs.webkit.org/show_bug.cgi?id=30234
     7
     8        * platform/mac/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
     9        * platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
     10        * platform/mac/editing/selection/script-tests/TEMPLATE.html: Added.
     11        * platform/mac/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added.
     12        (description.doubleClickOnElement):
     13        (doubleClickAt):
     14        (selectionShouldBe):
     15        * platform/win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
     16        * platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
     17        * platform/win/editing/selection/script-tests/TEMPLATE.html: Added.
     18        * platform/win/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added.
     19        (description.doubleClickOnElement):
     20        (doubleClickAt):
     21        (selectionShouldBe):
     22
    1232009-10-18  Pavel Feldman  <pfeldman@chromium.org>
    224

  • trunk/WebCore/ChangeLog

    r49764 r49767  
     12009-10-18  Erik Arvidsson  <arv@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Fixes issue where doubleclicking a word could select following adjacent newlines.
     6        https://bugs.webkit.org/show_bug.cgi?id=30234
     7
     8        Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html
     9               platform/mac/editing/selection/script-tests/TEMPLATE.html
     10               platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html
     11               platform/win/editing/selection/script-tests/TEMPLATE.html
     12
     13        * editing/VisibleSelection.cpp:
     14        (WebCore::VisibleSelection::appendTrailingWhitespace):
     15
    1162009-10-18  Kevin Ollivier  <kevino@theolliviers.com>
    217

  • trunk/WebCore/editing/VisibleSelection.cpp

    r48234 r49767  
    238238    for (; charIt.length(); charIt.advance(1)) {
    239239        UChar c = charIt.characters()[0];
    240         if (!isSpaceOrNewline(c) && c != noBreakSpace)
     240        if (!isSpaceOrNewline(c) && c != noBreakSpace || c == '\n')
    241241            break;
    242242        m_end = charIt.range()->endPosition();
Note: See TracChangeset for help on using the changeset viewer.