Changeset 49789 in webkit


Ignore:
Timestamp:
Oct 19, 2009 9:26:02 AM (15 years ago)
Author:
eric@webkit.org
Message:

2009-10-19 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Adam Barth.

[Qt] Remove deletion of outgoing FormData object when reply is finished.
The buffers will be destroyed a bit later, when the QNetworkReply is deleted.
Bug: ​https://bugs.webkit.org/show_bug.cgi?id=29551

  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/QNetworkReplyHandler.h:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r49788 r49789  
     12009-10-19  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
     2
     3        Reviewed by Adam Barth.
     4
     5        [Qt] Remove deletion of outgoing FormData object when reply is finished.
     6        The buffers will be destroyed a bit later, when the QNetworkReply is deleted.
     7        Bug: https://bugs.webkit.org/show_bug.cgi?id=29551
     8
     9        * platform/network/qt/QNetworkReplyHandler.cpp:
     10        * platform/network/qt/QNetworkReplyHandler.h:
     11
    1122009-10-19  Dimitri Glazkov  <dglazkov@chromium.org>
    213

  • trunk/WebCore/platform/network/qt/QNetworkReplyHandler.cpp

    r49100 r49789  
    113113}
    114114
    115 void FormDataIODevice::setParent(QNetworkReply* reply)
    116 {
    117     QIODevice::setParent(reply);
    118 
    119     connect(reply, SIGNAL(finished()), SLOT(slotFinished()), Qt::QueuedConnection);
    120 }
    121 
    122115bool FormDataIODevice::isSequential() const
    123116{
    124117    return true;
    125 }
    126 
    127 void FormDataIODevice::slotFinished()
    128 {
    129     deleteLater();
    130118}
    131119

  • trunk/WebCore/platform/network/qt/QNetworkReplyHandler.h

    r48028 r49789  
    9797    ~FormDataIODevice();
    9898
    99     void setParent(QNetworkReply*);
    10099    bool isSequential() const;
    101100
    … …  
    103102    qint64 readData(char*, qint64);
    104103    qint64 writeData(const char*, qint64);
    105 
    106 private Q_SLOTS:
    107     void slotFinished();
    108104
    109105private:
Note: See TracChangeset for help on using the changeset viewer.