Changeset 49816 in webkit

Timestamp:

Oct 19, 2009 3:10:38 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-19 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Eric Seidel.

Replace boolean operator indentation example with an if statement.

​https://bugs.webkit.org/show_bug.cgi?id=30538

• coding/coding-style.html: Replace boolean indenting example to use "if"

Location:

trunk/WebKitSite

Files:

• ChangeLog (modified) (1 diff)
• coding/coding-style.html (modified) (1 diff)

trunk/WebKitSite/ChangeLog

@@ +1 @@
+2009-10-19  Andrew Scherkus  <scherkus@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Replace boolean operator indentation example with an if statement.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30538
+
+        * coding/coding-style.html: Replace boolean indenting example to use "if"
+
 2009-10-16  Darin Adler  <darin@apple.com>
 

trunk/WebKitSite/coding/coding-style.html

@@ -121 +121 @@
 <h4 class="right">Right:</h4>
 <pre class="code">
-return attr->name() == srcAttr
+if (attr->name() == srcAttr
     || attr->name() == lowsrcAttr
-    || (attr->name() == usemapAttr && attr->value().domString()[0] != '#');
-</pre>
-
-<h4 class="wrong">Wrong:</h4>
-<pre class="code">
-return attr->name() == srcAttr ||
+    || (attr->name() == usemapAttr && attr->value().domString()[0] != '#'))
+    return;
+</pre>
+
+<h4 class="wrong">Wrong:</h4>
+<pre class="code">
+if (attr->name() == srcAttr ||
     attr->name() == lowsrcAttr ||
-    (attr->name() == usemapAttr && attr->value().domString()[0] != '#');
+    (attr->name() == usemapAttr && attr->value().domString()[0] != '#'))
+    return;
 </pre>
 </li>