Changeset 49818 in webkit

Timestamp:

Oct 19, 2009 3:36:31 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-19 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Language tag should include both language and country sub-tags,
case insensitive.
​https://bugs.webkit.org/show_bug.cgi?id=30440

• fast/js/navigator-language-expected.txt:
• fast/js/navigator-language.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/js/navigator-language-expected.txt (modified) (1 diff)
• fast/js/navigator-language.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-10-19  Shu Chang  <Chang.Shu@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        Language tag should include both language and country sub-tags,
+        case insensitive.
+        https://bugs.webkit.org/show_bug.cgi?id=30440
+
+        * fast/js/navigator-language-expected.txt:
+        * fast/js/navigator-language.html:
+
 2009-10-19  Daniel Bates  <dbates@webkit.org>
 

trunk/LayoutTests/fast/js/navigator-language-expected.txt

@@ -1 +1 @@
 Test for bug 29653: [Qt] Qt-based browser fails to show the right language translation.
-Language tags should follow the specification below:
-2.1.1.  Formatting of Language Tags
-
-   At all times, language tags and their subtags, including private use
-   and extensions, are to be treated as case insensitive: there exist
-   conventions for the capitalization of some of the subtags, but these
-   MUST NOT be taken to carry meaning.
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS navigator.language.substring(0,2) is 'en'
+PASS navigator.language.toLowerCase() is 'en-us'
 PASS successfullyParsed is true
 

trunk/LayoutTests/fast/js/navigator-language.html

@@ -8 +8 @@
 <p id="description"></p>
 <div id="console"></div>
+<!--
+Language tags should follow specification RFC5646:
+http://tools.ietf.org/html/rfc5646
+2.1.1.  Formatting of Language Tags
+
+   At all times, language tags and their subtags, including private use
+   and extensions, are to be treated as case insensitive: there exist
+   conventions for the capitalization of some of the subtags, but these
+   MUST NOT be taken to carry meaning.
+-->
 <script>
 description(
-"<pre>Test for bug 29653: [Qt] Qt-based browser fails to show the right language translation.\n\
-Language tags should follow the specification below:\n\
-2.1.1.  Formatting of Language Tags\n\
-\n\
-   At all times, language tags and their subtags, including private use\n\
-   and extensions, are to be treated as case insensitive: there exist\n\
-   conventions for the capitalization of some of the subtags, but these\n\
-   MUST NOT be taken to carry meaning.</pre>"
+"<pre>Test for bug 29653: [Qt] Qt-based browser fails to show the right language translation."
 );
 
@@ -25 +28 @@
 }
 
-shouldBe("navigator.language.substring(0,2)", "'en'");
+shouldBe("navigator.language.toLowerCase()", "'en-us'");
 
 var successfullyParsed = true;