Changeset 49929 in webkit

Timestamp:

Oct 21, 2009 4:57:01 PM (15 years ago)

Author:

dumi@chromium.org

Message:

Adding the ability to enable/disable functions in V8 at runtime.

Patch by Dumitru Daniliuc <​dumi@chromium.org> on 2009-10-21
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=30650

• bindings/scripts/CodeGeneratorV8.pm:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-21  Dumitru Daniliuc  <dumi@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Adding the ability to enable/disable functions in V8 at runtime.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30650
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+
 2009-10-21  Darin Adler  <darin@apple.com>
 

trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -1323 +1323 @@
         }
 
+        my $conditional = "";
+        if ($attrExt->{"EnabledAtRuntime"}) {
+            # Only call Set()/SetAccessor() if this method should be enabled
+            $enable_function = $interfaceName . $codeGenerator->WK_ucfirst($function->signature->name);
+            $conditional = "if (V8Custom::v8${enable_function}Enabled())\n";
+        }
+
         if ($attrExt->{"DoNotCheckDomainSecurity"} &&
             ($dataNode->extendedAttributes->{"CheckDomainSecurity"} || $interfaceName eq "DOMWindow")) {
@@ -1343 +1350 @@
 
   // $commentInfo
-  $template->SetAccessor(
+  $conditional $template->SetAccessor(
       v8::String::New("$name"),
       ${interfaceName}Internal::${name}AttrGetter,
@@ -1371 +1378 @@
 
   // $commentInfo
-  ${template}->Set(
+  $conditional ${template}->Set(
       v8::String::New("$name"),
       $templateFunction,