Changeset 49951 in webkit


Ignore:
Timestamp:
Oct 22, 2009 12:56:08 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-10-22 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Fix memory leak in QNetworkReplyHandler::abort().
In QNetworkReplyHandler::release(), m_reply should no longer point to its parent
after being released.
https://bugs.webkit.org/show_bug.cgi?id=30167

No layout test available as a non-functional fix.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r49950 r49951  
     12009-10-22  Shu Chang  <Chang.Shu@nokia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Qt] Fix memory leak in QNetworkReplyHandler::abort().
     6        In QNetworkReplyHandler::release(), m_reply should no longer point to its parent
     7        after being released.
     8        https://bugs.webkit.org/show_bug.cgi?id=30167
     9
     10        No layout test available as a non-functional fix.
     11
     12        * platform/network/qt/QNetworkReplyHandler.cpp:
     13        (WebCore::QNetworkReplyHandler::abort):
     14        (WebCore::QNetworkReplyHandler::release):
     15
    1162009-10-22  Pavel Feldman  <pfeldman@chromium.org>
    217
  • trunk/WebCore/platform/network/qt/QNetworkReplyHandler.cpp

    r49789 r49951  
    176176        reply->abort();
    177177        reply->deleteLater();
    178         deleteLater();
    179     }
     178    }
     179    deleteLater();
    180180}
    181181
     
    189189        // don't reach the slots in our instance.
    190190        QCoreApplication::removePostedEvents(this, QEvent::MetaCall);
     191        m_reply->setParent(0);
    191192        m_reply = 0;
    192193    }
Note: See TracChangeset for help on using the changeset viewer.