Changeset 49954 in webkit

Timestamp:

Oct 22, 2009 1:19:43 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-22 Jaime Yap <​jaimeyap@google.com>

Reviewed by Timothy Hatcher.

Makes a page reload optional when activating resource monitoring in
InspectorController. It leaves the default behavior as performing the reload.
Reload is an optional param so callsites do not have to change.

​https://bugs.webkit.org/show_bug.cgi?id=30684

No new tests added.

• inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):
• inspector/InspectorController.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorController.cpp (modified) (2 diffs)
• inspector/InspectorController.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-22  Jaime Yap  <jaimeyap@google.com>
+
+        Reviewed by Timothy Hatcher.
+
+        Makes a page reload optional when activating resource monitoring in
+        InspectorController. It leaves the default behavior as performing the reload.
+        Reload is an optional param so callsites do not have to change.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30684
+
+        No new tests added.
+
+        * inspector/InspectorController.cpp:
+        (WebCore::InspectorController::enableResourceTracking):
+        * inspector/InspectorController.h:
+
 2009-10-22  Shu Chang  <Chang.Shu@nokia.com>
 

trunk/WebCore/inspector/InspectorController.cpp

@@ -1048 +1048 @@
 }
 
-void InspectorController::enableResourceTracking(bool always)
+void InspectorController::enableResourceTracking(bool always, bool reload)
 {
     if (!enabled())
@@ -1064 +1064 @@
         m_frontend->resourceTrackingWasEnabled();
 
-    m_inspectedPage->mainFrame()->loader()->reload();
+    if (reload)
+        m_inspectedPage->mainFrame()->loader()->reload();
 }
 

trunk/WebCore/inspector/InspectorController.h

@@ -224 +224 @@
     void scriptImported(unsigned long identifier, const String& sourceString);
 
-    void enableResourceTracking(bool always = false);
+    void enableResourceTracking(bool always = false, bool reload = true);
     void disableResourceTracking(bool always = false);
     bool resourceTrackingEnabled() const { return m_resourceTrackingEnabled; }