Changeset 49977 in webkit

Timestamp:

Oct 23, 2009 7:07:39 AM (15 years ago)

Author:

benm@google.com

Message:

Fixes a leak in createThreadInternal on Android.
​https://bugs.webkit.org/show_bug.cgi?id=30698

Patch by Steve Block <​steveblock@google.com> on 2009-10-23
Reviewed by Dmitry Titov.

• wtf/ThreadingPthreads.cpp: Modified.

(WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/ThreadingPthreads.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-10-23  Steve Block  <steveblock@google.com>
+
+        Reviewed by Dmitry Titov.
+
+        Fixes a leak in createThreadInternal on Android.
+        https://bugs.webkit.org/show_bug.cgi?id=30698
+
+        * wtf/ThreadingPthreads.cpp: Modified.
+        (WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.
+
 2009-10-22  Geoffrey Garen  <ggaren@apple.com>
 

trunk/JavaScriptCore/wtf/ThreadingPthreads.cpp

@@ -168 +168 @@
     if (pthread_create(&threadHandle, 0, runThreadWithRegistration, static_cast<void*>(threadData))) {
         LOG_ERROR("Failed to create pthread at entry point %p with data %p", entryPoint, data);
+        delete threadData;
         return 0;
     }