Changeset 49994 in webkit


Ignore:
Timestamp:
Oct 23, 2009 1:26:10 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-10-23 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

Chrome Linux: fix caret positioning in LTR complex languages
The caret is positioned off by one in languages like Thai.

https://bugs.webkit.org/show_bug.cgi?id=28284

A group of us spent a while trying various approaches to write a test
for this; however, since it is only that the blinking cursor is
displayed incorrectly, we concluded it can not be tested.

(Patch by Hironori Bono.)

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::selectionRectForComplexText):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r49992 r49994  
     12009-10-23  Evan Martin  <evan@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Chrome Linux: fix caret positioning in LTR complex languages
     6        The caret is positioned off by one in languages like Thai.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=28284
     9
     10        A group of us spent a while trying various approaches to write a test
     11        for this; however, since it is only that the blinking cursor is
     12        displayed incorrectly, we concluded it can not be tested.
     13
     14        (Patch by Hironori Bono.)
     15
     16        * platform/graphics/chromium/FontLinux.cpp:
     17        (WebCore::Font::selectionRectForComplexText):
     18
    1192009-10-23  Tony Chang  <tony@chromium.org>
    220
  • trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

    r49909 r49994  
    669669    if (toX == -1 && !to)
    670670        toX = rightEdge;
    671     else if (!walker.rtl())
    672         toX += truncateFixedPointToInteger(toAdvance);
    673671
    674672    ASSERT(fromX != -1 && toX != -1);
Note: See TracChangeset for help on using the changeset viewer.