Changeset 50025 in webkit

Timestamp:

Oct 23, 2009 9:12:56 PM (14 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/7294131> Assertion failure in AuthenticationMac at
mac(const Credential&) after authenticating to MobileMe Gallery movie

Reviewed by Alexey Proskuryakov.

• platform/network/Credential.cpp:

(WebCore::Credential::Credential): Initialize m_persistence.
(WebCore::Credential::isEmpty): Made this method const.

• platform/network/Credential.h:
• platform/network/mac/AuthenticationMac.mm:

(WebCore::mac): Return nil if the Credential is empty.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/Credential.cpp (modified) (2 diffs)
• platform/network/Credential.h (modified) (1 diff)
• platform/network/mac/AuthenticationMac.mm (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-23  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Alexey Proskuryakov.
+
+        <rdar://problem/7294131> Assertion failure in AuthenticationMac at
+        mac(const Credential&) after authenticating to MobileMe Gallery movie
+
+        * platform/network/Credential.cpp:
+        (WebCore::Credential::Credential): Initialize m_persistence.
+        (WebCore::Credential::isEmpty): Made this method const.
+        * platform/network/Credential.h:
+        * platform/network/mac/AuthenticationMac.mm:
+        (WebCore::mac): Return nil if the Credential is empty.
+
 2009-10-23  Brian Weinstein  <bweinstein@apple.com>
 

trunk/WebCore/platform/network/Credential.cpp

@@ -33 +33 @@
     : m_user("")
     , m_password("")
+    , m_persistence(CredentialPersistenceNone)
 {
 }
@@ -45 +46 @@
 }
 
-bool Credential::isEmpty()
+bool Credential::isEmpty() const
 {
     return m_user.isEmpty() && m_password.isEmpty();

trunk/WebCore/platform/network/Credential.h

@@ -42 +42 @@
     Credential(const String& user, const String& password, CredentialPersistence);
     
-    bool isEmpty();
+    bool isEmpty() const;
     
     const String& user() const;

trunk/WebCore/platform/network/mac/AuthenticationMac.mm

@@ -151 +151 @@
 NSURLCredential *mac(const Credential& coreCredential)
 {
+    if (coreCredential.isEmpty())
+        return nil;
+
     NSURLCredentialPersistence persistence = NSURLCredentialPersistenceNone;
     switch (coreCredential.persistence()) {