Changeset 50032 in webkit

Timestamp:

Oct 24, 2009 4:08:00 PM (14 years ago)

Author:

timothy@apple.com

Message:

Call updateSelection() in a few places so hovering in the Web Inspector's
Elements panel always has the correct row selection height.

​https://bugs.webkit.org/show_bug.cgi?id=30735

Reviewed by Pavel Feldman.

• inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
(WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.

• inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ElementsTreeOutline.js (modified) (3 diffs)
• inspector/front-end/inspector.css (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-24  Timothy Hatcher  <timothy@apple.com>
+
+        Call updateSelection() in a few places so hovering in the Web Inspector's
+        Elements panel always has the correct row selection height.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30735
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
+        (WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.
+        * inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
+
 2009-10-24  Timothy Hatcher  <timothy@apple.com>
 

trunk/WebCore/inspector/front-end/ElementsTreeOutline.js

@@ -329 +329 @@
                 this._addAttributeElement.parentNode.removeChild(this._addAttributeElement);
             delete this._addAttributeElement;
+
+            this.updateSelection();
         }
 
@@ -343 +345 @@
             removeAddAttributeSpan.call(this);
     },
-    
+
     updateSelection: function()
     {
@@ -544 +546 @@
             tag.appendChild(document.createTextNode('>'));
         }
+
+        this.updateSelection();
     },
 

trunk/WebCore/inspector/front-end/inspector.css

@@ -1164 +1164 @@
     margin-left: 1px;
     margin-right: 1px;
+    white-space: nowrap;
 }