Changeset 50051 in webkit

Timestamp:

Oct 26, 2009 3:29:21 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-26 Kinuko Yasuda <​kinuko@google.com>

Reviewed by Jan Alonzo.

Bug 30619: [Linux] Menu key doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=30619

Test: manual-tests/keyboard-menukey-event.html
No new layout tests: testing this will require changes in the test
controller in a platform-specific way.

• platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
• platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return V_APPS instead of VK_MENU.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/keyboard-menukey-event.html (added)
• platform/chromium/KeyCodeConversionGtk.cpp (modified) (2 diffs)
• platform/gtk/KeyEventGtk.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-26  Kinuko Yasuda  <kinuko@google.com>
+
+        Reviewed by Jan Alonzo.
+
+        Bug 30619: [Linux] Menu key doesn't work
+        https://bugs.webkit.org/show_bug.cgi?id=30619
+
+        Test: manual-tests/keyboard-menukey-event.html
+        No new layout tests: testing this will require changes in the test
+        controller in a platform-specific way.
+
+        * platform/chromium/KeyCodeConversionGtk.cpp:
+        (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
+        GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
+        * platform/gtk/KeyEventGtk.cpp:
+        (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
+        GDK_Menu to return V_APPS instead of VK_MENU.
+
 2009-10-25  Anton Muhin  <antonm@chromium.org>
 

trunk/WebCore/platform/chromium/KeyCodeConversionGtk.cpp

@@ -92 +92 @@
         return VKEY_CONTROL; // (11) CTRL key
     case GDK_Menu:
+        return VKEY_APPS;  // (5D) Applications key (Natural keyboard)
     case GDK_Alt_L:
     case GDK_Alt_R:
@@ -262 +263 @@
     case GDK_Meta_R:
         return VKEY_RWIN; // (5C) Right Windows key (Natural keyboard)
-        // VKEY_APPS (5D) Applications key (Natural keyboard)
         // VKEY_SLEEP (5F) Computer Sleep key
         // VKEY_SEPARATOR (6C) Separator key

trunk/WebCore/platform/gtk/KeyEventGtk.cpp

@@ -201 +201 @@
             return VK_CONTROL; // (11) CTRL key
         case GDK_Menu:
+            return VK_APPS;  // (5D) Applications key (Natural keyboard)
         case GDK_Alt_L:
         case GDK_Alt_R:
@@ -371 +372 @@
         case GDK_Meta_R:
             return VK_RWIN; // (5C) Right Windows key (Natural keyboard)
-            // VK_APPS (5D) Applications key (Natural keyboard)
             // VK_SLEEP (5F) Computer Sleep key
             // VK_SEPARATOR (6C) Separator key