Changeset 50116 in webkit

Timestamp:

Oct 26, 2009 5:19:33 PM (15 years ago)

Author:

beidson@apple.com

Message:

<rdar://problem/7289467> and ​http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/grandparent-completion-starts-redirect.html

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.

LayoutTests:

• fast/loader/grandparent-completion-starts-redirect-expected.txt: Added.
• fast/loader/grandparent-completion-starts-redirect.html: Added.
• fast/loader/resources/meta-redirect-to-notify-done.html: Added.
• fast/loader/resources/parent-of-redirect.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/loader/grandparent-completion-starts-redirect-expected.txt (added)
• LayoutTests/fast/loader/grandparent-completion-starts-redirect.html (added)
• LayoutTests/fast/loader/resources/meta-redirect-to-notify-done.html (added)
• LayoutTests/fast/loader/resources/parent-of-redirect.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/loader/FrameLoader.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-10-26  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Darin Adler.
+
+        <rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.
+
+        * fast/loader/grandparent-completion-starts-redirect-expected.txt: Added.
+        * fast/loader/grandparent-completion-starts-redirect.html: Added.
+        * fast/loader/resources/meta-redirect-to-notify-done.html: Added.
+        * fast/loader/resources/parent-of-redirect.html: Added.
+
 2009-10-26  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-26  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Darin Adler.
+
+        <rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.
+
+        Test: fast/loader/grandparent-completion-starts-redirect.html
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.
+
 2009-10-26  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/loader/FrameLoader.cpp

@@ -1730 +1730 @@
 {
     RefPtr<Frame> protect(m_frame);
-    for (Frame* child = m_frame->tree()->firstChild(); child; child = child->tree()->nextSibling())
-        child->redirectScheduler()->startTimer();
+
+    for (Frame* descendant = m_frame->tree()->traverseNext(m_frame); descendant; descendant = descendant->tree()->traverseNext(m_frame))
+        descendant->redirectScheduler()->startTimer();
+    
     if (Frame* parent = m_frame->tree()->parent())
         parent->loader()->checkCompleted();
+
     if (m_frame->view())
         m_frame->view()->maintainScrollPositionAtAnchor(0);