Changeset 50220 in webkit


Ignore:
Timestamp:
Oct 28, 2009 10:02:16 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

Expands upon the new funtionality which allows platforms to indicate
that a particular object should not be ignored, so that they can
specify that an object should be ignored or that it should be left up
to the default handling to decide.

  • accessibility/AccessibilityObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp:
  • accessibility/gtk/AccessibilityObjectAtk.cpp:
  • accessibility/mac/AccessibilityObjectMac.mm:
  • accessibility/qt/AccessibilityObjectQt.cpp:
  • accessibility/win/AccessibilityObjectWin.cpp:
  • accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
Location:
trunk/WebCore
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r50219 r50220  
     12009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
     2
     3        Reviewed by Jan Alonzo.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=25897
     6        [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
     7
     8        Expands upon the new funtionality which allows platforms to indicate
     9        that a particular object should not be ignored, so that they can
     10        specify that an object should be ignored or that it should be left up
     11        to the default handling to decide.
     12
     13        * accessibility/AccessibilityObject.h:
     14        * accessibility/chromium/AccessibilityObjectChromium.cpp:
     15        * accessibility/gtk/AccessibilityObjectAtk.cpp:
     16        * accessibility/mac/AccessibilityObjectMac.mm:
     17        * accessibility/qt/AccessibilityObjectQt.cpp:
     18        * accessibility/win/AccessibilityObjectWin.cpp:
     19        * accessibility/wx/AccessibilityObjectWx.cpp:
     20        (AccessibilityObject::accessibilityPlatformIncludesObject):
     21        * accessibility/AccessibilityRenderObject.cpp:
     22        (AccessibilityRenderObject::accessibilityIsIgnored):
     23
     24
    1252009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
    226
  • trunk/WebCore/accessibility/AccessibilityObject.h

    r50196 r50220  
    190190};
    191191   
     192enum AccessibilityObjectPlatformInclusion {
     193    IncludeObject,
     194    IgnoreObject,
     195    DefaultBehavior,
     196};
     197
    192198struct VisiblePositionRange {
    193199
     
    461467#endif
    462468
    463     // gives platforms the opportunity to indicate that an object shouldn't be ignored
     469    // gives platforms the opportunity to indicate if and how an object should be included
    464470#if HAVE(ACCESSIBILITY)
    465     bool accessibilityPlatformIncludesObject() const;
     471    AccessibilityObjectPlatformInclusion accessibilityPlatformIncludesObject() const;
    466472#else
    467     bool accessibilityPlatformIncludesObject() const { return false; }
     473    AccessibilityObjectPlatformInclusion accessibilityPlatformIncludesObject() const { return DefaultBehavior; }
    468474#endif
    469475
  • trunk/WebCore/accessibility/AccessibilityRenderObject.cpp

    r50196 r50220  
    12601260{
    12611261    // is the platform is interested in this object?
    1262     if (accessibilityPlatformIncludesObject())
    1263         return false;
     1262    AccessibilityObjectPlatformInclusion decision = accessibilityPlatformIncludesObject();
     1263    if (decision == IncludeObject)
     1264        return false;
     1265    if (decision == IgnoreObject)
     1266        return true;
     1267    // the decision must, therefore, be DefaultBehavior.
    12641268
    12651269    // ignore invisible element
  • trunk/WebCore/accessibility/chromium/AccessibilityObjectChromium.cpp

    r50053 r50220  
    3535}
    3636
    37 bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     37AccessibilityObjectPlatformInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const
    3838{
    39     return false;
     39    return DefaultBehavior;
    4040}
    4141
  • trunk/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp

    r50053 r50220  
    3333}
    3434
    35 bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     35AccessibilityObjectPlatformInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const
    3636{
    3737    // When a list item is made up entirely of children (e.g. paragraphs)
     
    4040        AccessibilityObject* parent = parentObject();
    4141        if (parent && parent->isList())
    42             return true;
     42            return IncludeObject;
    4343    }
    4444
    45     return false;
     45    return DefaultBehavior;
    4646}
    4747
  • trunk/WebCore/accessibility/mac/AccessibilityObjectMac.mm

    r50053 r50220  
    4242}
    4343
    44 bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     44AccessibilityObjectPlatformInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const
    4545{
    46     return false;
     46    return DefaultBehavior;
    4747}
    4848   
  • trunk/WebCore/accessibility/qt/AccessibilityObjectQt.cpp

    r50053 r50220  
    3030}
    3131
    32 bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     32AccessibilityObjectPlatformInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const
    3333{
    34     return false;
     34    return DefaultBehavior;
    3535}
    3636
  • trunk/WebCore/accessibility/win/AccessibilityObjectWin.cpp

    r50053 r50220  
    3636}
    3737
    38 bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     38AccessibilityObjectPlatformInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const
    3939{
    40     return false;
     40    return DefaultBehavior;
    4141}
    4242
  • trunk/WebCore/accessibility/wx/AccessibilityObjectWx.cpp

    r50053 r50220  
    3030}
    3131
    32 bool AccessibilityObject::accessibilityPlatformIncludesObject() const
     32AccessibilityObjectPlatformInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const
    3333{
    34     return false;
     34    return DefaultBehavior;
    3535}
    3636
Note: See TracChangeset for help on using the changeset viewer.