Changeset 50303 in webkit

Timestamp:

Oct 29, 2009 2:59:33 PM (14 years ago)

Author:

timothy@apple.com

Message:

Fix tabbing through element attributes in the Web Insector.

​https://bugs.webkit.org/show_bug.cgi?id=30429

Reviewed by Pavel Feldman.

• inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): Don't call _updateTitle,
it is called for us when removeAttribute succeeds in the back-end.
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto except for nodeValue.
(WebInspector.ElementsTreeElement.prototype._editingCancelled): Don't call _updateTitle, editing code reverts.
(WebInspector.ElementsTreeElement.prototype._updateTitle): Return early if we are editing.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ElementsTreeOutline.js (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-29  Timothy Hatcher  <timothy@apple.com>
+
+        Fix tabbing through element attributes in the Web Insector.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30429
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): Don't call _updateTitle,
+        it is called for us when removeAttribute succeeds in the back-end.
+        (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto except for nodeValue.
+        (WebInspector.ElementsTreeElement.prototype._editingCancelled): Don't call _updateTitle, editing code reverts.
+        (WebInspector.ElementsTreeElement.prototype._updateTitle): Return early if we are editing.
+
 2009-10-29  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/inspector/front-end/ElementsTreeOutline.js

@@ -732 +732 @@
         if (!parseElement.hasAttributes()) {
             this.representedObject.removeAttribute(attributeName);
-            this._updateTitle();
             moveToNextAttributeIfNeeded.call(this);
             return;
@@ -749 +748 @@
             this.representedObject.removeAttribute(attributeName);
 
-        this._updateTitle();
-
         this.treeOutline.focusedNodeChanged(true);
 
@@ -769 +766 @@
 
         textNode.nodeValue = newText;
-        this._updateTitle();
+
+        // No need to call _updateTitle here, it will be called after the nodeValue is committed.
     },
 
@@ -776 +774 @@
         delete this._editing;
 
-        this._updateTitle();
+        // No need to call _updateTitle here, the editing code will revert to the original text.
     },
 
     _updateTitle: function()
     {
+        // If we are editing, return early to prevent canceling the edit.
+        // After editing is committed _updateTitle will be called.
+        if (this._editing)
+            return;
+
         var title = this._nodeTitleInfo(this.representedObject, this.hasChildren, WebInspector.linkifyURL).title;
         this.title = "<span class=\"highlight\">" + title + "</span>";