Changeset 50535 in webkit


Ignore:
Timestamp:
Nov 4, 2009 4:50:59 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-04 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider doesn't have a thumb
https://bugs.webkit.org/show_bug.cgi?id=31135

Fixed an incorrect if statement that prevents volume slider
being updated.

The statement checks if the slider value equals to the current
volume value of the media control to avoid updating the volume
slider. Updating the volume slider control shouldn't be within
this condition because we explicitly set them to be equals
during creation of the controls and also when mouse events are
received on the volume control.

No new tests because existing code breaks:
LayoutTests/media/video-volume-slider.html

It should now start passing on Chromium.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Update the volume slider regardless of the current volume value of the media control.
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r50534 r50535  
     12009-11-04  Alpha Lam  <hclam@chromium.org>
     2
     3        Reviewed by Eric Carlson.
     4
     5        Volume slider doesn't have a thumb
     6        https://bugs.webkit.org/show_bug.cgi?id=31135
     7
     8        Fixed an incorrect if statement that prevents volume slider
     9        being updated.
     10
     11        The statement checks if the slider value equals to the current
     12        volume value of the media control to avoid updating the volume
     13        slider. Updating the volume slider control shouldn't be within
     14        this condition because we explicitly set them to be equals
     15        during creation of the controls and also when mouse events are
     16        received on the volume control.
     17
     18        No new tests because existing code breaks:
     19        LayoutTests/media/video-volume-slider.html
     20
     21        It should now start passing on Chromium.
     22
     23        * rendering/MediaControlElements.cpp:
     24        (WebCore::MediaControlVolumeSliderElement::update):
     25        Update the volume slider regardless of the current volume value
     26        of the media control.
     27
    1282009-11-04  Jenn Braithwaite  <jennb@chromium.org>
    229
  • trunk/WebCore/rendering/MediaControlElements.cpp

    r50476 r50535  
    651651{
    652652    float volume = m_mediaElement->volume();
    653     if (value().toFloat() != volume) {
     653    if (value().toFloat() != volume)
    654654        setValue(String::number(volume));
    655         MediaControlInputElement::update();
    656     }
     655    MediaControlInputElement::update();
    657656}
    658657
Note: See TracChangeset for help on using the changeset viewer.