Changeset 50579 in webkit


Ignore:
Timestamp:
Nov 5, 2009 2:46:56 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-05 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Adele Peterson.

The number of selected lines in textarea after a shift-PageDown
may differ. The test case is modified so that it will not depend
on the exact number of lines selected. This should resolve regression
on platforms like Qt and GTK.
​https://bugs.webkit.org/show_bug.cgi?id=31122

  • editing/selection/shrink-selection-after-shift-pagedown.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r50576 r50579  
     12009-11-05  Shu Chang  <Chang.Shu@nokia.com>
     2
     3        Reviewed by Adele Peterson.
     4
     5        The number of selected lines in textarea after a shift-PageDown
     6        may differ. The test case is modified so that it will not depend
     7        on the exact number of lines selected. This should resolve regression
     8        on platforms like Qt and GTK.
     9        https://bugs.webkit.org/show_bug.cgi?id=31122
     10
     11        * editing/selection/shrink-selection-after-shift-pagedown.html:
     12
    1132009-11-05  Pavel Feldman  <pfeldman@chromium.org>
    214

  • trunk/LayoutTests/editing/selection/shrink-selection-after-shift-pagedown.html

    r50165 r50579  
    88       
    99        var ta = document.getElementById('ta');
    10         ta.setSelectionRange(3, 14);
    11        
     10        ta.setSelectionRange(4, 16);
     11
     12        var lastSelectedLine;
    1213        if (window.eventSender) {
    1314            eventSender.keyDown("pageDown",["shiftKey"]);
     15            lastSelectedLine = (ta.value).substring(ta.selectionEnd - 4, ta.selectionEnd);
    1416            eventSender.keyDown("upArrow",["shiftKey"]);
    1517        }
    … …  
    1719        var result;
    1820        var selectedText = (ta.value).substring(ta.selectionStart, ta.selectionEnd);
    19         if (selectedText.indexOf('NO') == -1)
     21        if ((selectedText.indexOf(lastSelectedLine) == -1) && (selectedText.indexOf('L01') == -1))
    2022            result = "SUCCESS: The selection shrunk correctly";
    2123        else
    … …  
    3436</p>
    3537<textarea rows=10 id="ta">
    36 NO
    37 YES
    38 YES
    39 YES
    40 YES
    41 YES
    42 YES
    43 YES
    44 YES
    45 YES
    46 NO
    47 NO
    48 NO
    49 NO
    50 NO
    51 NO
    52 NO
     38L01
     39L02
     40L03
     41L04
     42L05
     43L06
     44L07
     45L08
     46L09
     47L10
     48L11
     49L12
     50L13
     51L14
     52L15
     53L16
    5354</textarea>
    5455<p id="result">TEST HAS NOT RUN</p>
Note: See TracChangeset for help on using the changeset viewer.