Changeset 50618 in webkit

Timestamp:

Nov 7, 2009 6:31:48 PM (14 years ago)

Author:

dbates@webkit.org

Message:

2009-11-07 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=20780

Fixes an issue where the onchange event handler is not fired when the
input field is autocompleted.

We cannot test this using DRT since DRT cannot emulate autocompletion.
So, a manual-test is included.

Tests: manual-tests/autocompletion-fire-onchange.html

• manual-tests/autocompletion-fire-onchange.html: Added.
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/autocompletion-fire-onchange.html (added)
• rendering/RenderTextControl.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-07  Daniel Bates  <dbates@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=20780
+        
+        Fixes an issue where the onchange event handler is not fired when the 
+        input field is autocompleted.
+        
+        We cannot test this using DRT since DRT cannot emulate autocompletion.
+        So, a manual-test is included.
+
+        Tests: manual-tests/autocompletion-fire-onchange.html
+
+        * manual-tests/autocompletion-fire-onchange.html: Added.
+        * rendering/RenderTextControl.cpp:
+        (WebCore::RenderTextControl::setInnerTextValue):
+
 2009-11-07  Benjamin Otte  <otte@gnome.org>
 

trunk/WebCore/rendering/RenderTextControl.cpp

@@ -196 +196 @@
         }
 
-        m_edited = false;
+        // We set m_userEdited to false since this change was not explicty made by the user (say, via typing on the keyboard), see <rdar://problem/5359921>.
         m_userEdited = false;
     }