Changeset 50625 in webkit


Ignore:
Timestamp:
Nov 8, 2009 11:01:51 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Holger Freyther.

ResourceRequest to be class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=30670

Started as a compilation fix for Symbian where the compiler makes a distinction between
class and struct in function argument signatures.
Changed all forward declarations of ResourceRequest to have class in the forward
declaration instead of struct and changed the definition of ResourceRequest to be class
and added access qualifiers where missing. Additionally two references of friend
struct ResourceRequestBase changed to class instead.

  • history/HistoryItem.h:
  • inspector/InspectorController.h:
  • inspector/InspectorResource.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/ResourceLoadNotifier.h:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoader.h:
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheHost.h:
  • platform/CrossThreadCopier.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.h:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.h:
  • platform/network/chromium/ResourceRequest.h:
  • platform/network/curl/ResourceRequest.h:
  • platform/network/qt/ResourceRequest.h:
  • platform/network/soup/ResourceRequest.h:
  • xml/XMLHttpRequest.h:

2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Holger Freyther.

ResourceRequest to be class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=30670

Started as a compilation fix for Symbian where the compiler makes a distinction between
class and struct in function argument signatures.
Changed forward declaration of ResourceRequest to have class in the forward
declaration instead of struct.

  • WebDownload.h:
Location:
trunk
Files:
27 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r50623 r50625  
     12009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
     2
     3        Reviewed by Holger Freyther.
     4
     5        ResourceRequest to be class instead of struct
     6        https://bugs.webkit.org/show_bug.cgi?id=30670
     7
     8        Started as a compilation fix for Symbian where the compiler makes a distinction between
     9        class and struct in function argument signatures.
     10        Changed all forward declarations of ResourceRequest to have class in the forward
     11        declaration instead of struct and changed the definition of ResourceRequest to be class
     12        and added access qualifiers where missing. Additionally two references of friend
     13        struct ResourceRequestBase changed to class instead.
     14
     15        * history/HistoryItem.h:
     16        * inspector/InspectorController.h:
     17        * inspector/InspectorResource.h:
     18        * loader/DocumentThreadableLoader.h:
     19        * loader/FrameLoaderClient.h:
     20        * loader/MainResourceLoader.h:
     21        * loader/ResourceLoadNotifier.h:
     22        * loader/SubresourceLoader.h:
     23        * loader/SubresourceLoaderClient.h:
     24        * loader/ThreadableLoader.h:
     25        * loader/WorkerThreadableLoader.h:
     26        * loader/appcache/ApplicationCache.h:
     27        * loader/appcache/ApplicationCacheHost.h:
     28        * platform/CrossThreadCopier.h:
     29        * platform/network/ResourceHandle.h:
     30        * platform/network/ResourceHandleClient.h:
     31        * platform/network/ResourceRequestBase.h:
     32        * platform/network/cf/ResourceRequest.h:
     33        * platform/network/cf/ResourceRequestCFNet.h:
     34        * platform/network/chromium/ResourceRequest.h:
     35        * platform/network/curl/ResourceRequest.h:
     36        * platform/network/qt/ResourceRequest.h:
     37        * platform/network/soup/ResourceRequest.h:
     38        * xml/XMLHttpRequest.h:
     39
    1402009-11-08  Dan Bernstein  <mitz@apple.com>
    241
  • trunk/WebCore/history/HistoryItem.h

    r45675 r50625  
    5151class Image;
    5252class KURL;
    53 struct ResourceRequest;
     53class ResourceRequest;
    5454
    5555typedef Vector<RefPtr<HistoryItem> > HistoryItemVector;
  • trunk/WebCore/inspector/InspectorController.h

    r50501 r50625  
    7272class Node;
    7373class Page;
    74 struct ResourceRequest;
     74class ResourceRequest;
    7575class ResourceResponse;
    7676class ResourceError;
  • trunk/WebCore/inspector/InspectorResource.h

    r49960 r50625  
    5252    class ResourceResponse;
    5353
    54     struct ResourceRequest;
     54    class ResourceRequest;
    5555
    5656    class InspectorResource : public RefCounted<InspectorResource> {
  • trunk/WebCore/loader/DocumentThreadableLoader.h

    r47388 r50625  
    4242    class Document;
    4343    class KURL;
    44     struct ResourceRequest;
     44    class ResourceRequest;
    4545    class ThreadableLoaderClient;
    4646
  • trunk/WebCore/loader/FrameLoaderClient.h

    r50580 r50625  
    6565    class ResourceHandle;
    6666    class ResourceLoader;
    67     struct ResourceRequest;
     67    class ResourceRequest;
    6868    class ResourceResponse;
    6969    class ScriptString;
  • trunk/WebCore/loader/MainResourceLoader.h

    r46609 r50625  
    4141
    4242    class FormState;
    43     struct ResourceRequest;
     43    class ResourceRequest;
    4444
    4545    class MainResourceLoader : public ResourceLoader {
  • trunk/WebCore/loader/ResourceLoadNotifier.h

    r49916 r50625  
    4242class ResourceResponse;
    4343class ScriptString;
    44 struct ResourceRequest;
     44class ResourceRequest;
    4545
    4646class ResourceLoadNotifier : public Noncopyable {
  • trunk/WebCore/loader/SubresourceLoader.h

    r41225 r50625  
    3434namespace WebCore {
    3535
    36     struct ResourceRequest;
     36    class ResourceRequest;
    3737    class SubresourceLoaderClient;
    3838   
  • trunk/WebCore/loader/SubresourceLoaderClient.h

    r41225 r50625  
    3434class AuthenticationChallenge;
    3535class ResourceError;
    36 struct ResourceRequest;
     36class ResourceRequest;
    3737class ResourceResponse;
    3838class SubresourceLoader;
  • trunk/WebCore/loader/ThreadableLoader.h

    r47388 r50625  
    3939
    4040    class ResourceError;
    41     struct ResourceRequest;
     41    class ResourceRequest;
    4242    class ResourceResponse;
    4343    class ScriptExecutionContext;
  • trunk/WebCore/loader/WorkerThreadableLoader.h

    r47291 r50625  
    4848
    4949    class ResourceError;
    50     struct ResourceRequest;
     50    class ResourceRequest;
    5151    class WorkerContext;
    5252    class WorkerLoaderProxy;
  • trunk/WebCore/loader/appcache/ApplicationCache.h

    r47512 r50625  
    4343class KURL;
    4444
    45 struct ResourceRequest;
     45class ResourceRequest;
    4646
    4747typedef Vector<std::pair<KURL, KURL> > FallbackURLVector;
  • trunk/WebCore/loader/appcache/ApplicationCacheHost.h

    r48701 r50625  
    4646    class ResourceLoader;
    4747    class ResourceError;
    48     struct ResourceRequest;
     48    class ResourceRequest;
    4949    class ResourceResponse;
    5050    class SubstituteData;
  • trunk/WebCore/platform/CrossThreadCopier.h

    r49734 r50625  
    4242
    4343    class ResourceError;
    44     struct ResourceRequest;
     44    class ResourceRequest;
    4545    class ResourceResponse;
    4646    class String;
  • trunk/WebCore/platform/network/ResourceHandle.h

    r46535 r50625  
    8585class ResourceHandleClient;
    8686class ResourceHandleInternal;
    87 struct ResourceRequest;
     87class ResourceRequest;
    8888class ResourceResponse;
    8989class SchedulePair;
  • trunk/WebCore/platform/network/ResourceHandleClient.h

    r42483 r50625  
    5151    class ResourceHandle;
    5252    class ResourceError;
    53     struct ResourceRequest;
     53    class ResourceRequest;
    5454    class ResourceResponse;
    5555
  • trunk/WebCore/platform/network/ResourceRequestBase.h

    r50226 r50625  
    4747    const int unspecifiedTimeoutInterval = INT_MAX;
    4848
    49     struct ResourceRequest;
     49    class ResourceRequest;
    5050    struct CrossThreadResourceRequestData;
    5151
  • trunk/WebCore/platform/network/cf/ResourceRequest.h

    r47907 r50625  
    3535namespace WebCore {
    3636
    37     struct ResourceRequest : ResourceRequestBase {
    38 
     37    class ResourceRequest : public ResourceRequestBase {
     38    public:
    3939        ResourceRequest(const String& url)
    4040            : ResourceRequestBase(KURL(ParsedURLString, url), UseProtocolCachePolicy)
     
    6565
    6666    private:
    67         friend struct ResourceRequestBase;
     67        friend class ResourceRequestBase;
    6868
    6969        void doUpdatePlatformRequest();
  • trunk/WebCore/platform/network/cf/ResourceRequestCFNet.h

    r41225 r50625  
    3131namespace WebCore {
    3232
    33     struct ResourceRequest;
     33    class ResourceRequest;
    3434
    3535    void getResourceRequest(ResourceRequest&, CFURLRequestRef);
  • trunk/WebCore/platform/network/chromium/ResourceRequest.h

    r48175 r50625  
    3636    class Frame;
    3737
    38     struct ResourceRequest : public ResourceRequestBase {
     38    class ResourceRequest : public ResourceRequestBase {
    3939    public:
    4040        enum TargetType {
  • trunk/WebCore/platform/network/curl/ResourceRequest.h

    r47907 r50625  
    3434namespace WebCore {
    3535
    36     struct ResourceRequest : ResourceRequestBase {
    37 
     36    class ResourceRequest : public ResourceRequestBase {
     37    public:
    3838        ResourceRequest(const String& url)
    3939            : ResourceRequestBase(KURL(ParsedURLString, url), UseProtocolCachePolicy)
  • trunk/WebCore/platform/network/qt/ResourceRequest.h

    r50454 r50625  
    3737namespace WebCore {
    3838
    39     struct ResourceRequest : ResourceRequestBase {
    40 
     39    class ResourceRequest : public ResourceRequestBase {
     40    public:
    4141        ResourceRequest(const String& url)
    4242            : ResourceRequestBase(KURL(ParsedURLString, url), UseProtocolCachePolicy)
  • trunk/WebCore/platform/network/soup/ResourceRequest.h

    r47907 r50625  
    3434namespace WebCore {
    3535
    36     struct ResourceRequest : ResourceRequestBase {
    37 
     36    class ResourceRequest : public ResourceRequestBase {
     37    public:
    3838        ResourceRequest(const String& url)
    3939            : ResourceRequestBase(KURL(ParsedURLString, url), UseProtocolCachePolicy)
     
    6767
    6868    private:
    69         friend struct ResourceRequestBase;
     69        friend class ResourceRequestBase;
    7070
    7171        void doUpdatePlatformRequest() {};
  • trunk/WebCore/xml/XMLHttpRequest.h

    r49992 r50625  
    3636class Document;
    3737class File;
    38 struct ResourceRequest;
     38class ResourceRequest;
    3939class TextResourceDecoder;
    4040class ThreadableLoader;
  • trunk/WebKit/win/ChangeLog

    r50567 r50625  
     12009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
     2
     3        Reviewed by Holger Freyther.
     4
     5        ResourceRequest to be class instead of struct
     6        https://bugs.webkit.org/show_bug.cgi?id=30670
     7
     8        Started as a compilation fix for Symbian where the compiler makes a distinction between
     9        class and struct in function argument signatures.
     10        Changed forward declaration of ResourceRequest to have class in the forward
     11        declaration instead of struct.
     12
     13        * WebDownload.h:
     14
    1152009-11-05  Adam Roben  <aroben@apple.com>
    216
  • trunk/WebKit/win/WebDownload.h

    r46359 r50625  
    3939    class KURL;
    4040    class ResourceHandle;
    41     struct ResourceRequest;
     41    class ResourceRequest;
    4242    class ResourceResponse;
    4343}
Note: See TracChangeset for help on using the changeset viewer.