Changeset 50627 in webkit

Timestamp:

Nov 8, 2009 11:47:22 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2009-11-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] committing style edit
clears elements panel selection.

​https://bugs.webkit.org/show_bug.cgi?id=31242

• inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.update):
• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ElementsTreeOutline.js (modified) (2 diffs)
• inspector/front-end/StylesSidebarPane.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Web Inspector: [REGRESSION] committing style edit
+        clears elements panel selection.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31242
+
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeOutline.prototype.update):
+        * inspector/front-end/StylesSidebarPane.js:
+        (WebInspector.StylePropertyTreeElement.prototype.):
+        (WebInspector.StylePropertyTreeElement.prototype):
+
 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
 

trunk/WebCore/inspector/front-end/ElementsTreeOutline.js

@@ -105 +105 @@
     update: function()
     {
+        var selectedNode = this.selectedTreeElement ? this.selectedTreeElement.representedObject : null;
+
         this.removeChildren();
 
@@ -126 +128 @@
         }
 
-        this.updateSelection();
+        if (selectedNode)
+            this.revealAndSelectNode(selectedNode);
     },
 

trunk/WebCore/inspector/front-end/StylesSidebarPane.js

@@ -94 +94 @@
 
         var body = this.bodyElement;
-        if (!refresh || !node) {
+
+        if (!node) {
             body.removeChildren();
             this.sections = [];
-        }
-
-        if (!node)
-            return;
+            return;
+        }
 
         var self = this;
@@ -1355 +1354 @@
                 self.updateAll(true);
 
-            if (!self.rule)
+            if (!section.rule)
                 WebInspector.panels.elements.treeOutline.update();
         }