Changeset 50659 in webkit


Ignore:
Timestamp:
Nov 9, 2009 7:38:30 AM (14 years ago)
Author:
Laszlo Gombos
Message:

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Christiansen.

[Qt] Remove the sessionStorage setting (per Page)
https://bugs.webkit.org/show_bug.cgi?id=31249

This setting allows to run sessionStorage on/off on a per page
basis. Remove this prematurely exposed API.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::database): (tst_QWebPage::testOptionalJSObjects):
Location:
trunk/WebKit/qt
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/qt/Api/qwebsettings.cpp

    r50456 r50659  
    207207                                      global->attributes.value(QWebSettings::LocalContentCanAccessRemoteUrls));
    208208        settings->setAllowUniversalAccessFromFileURLs(value);
    209 
    210         value = attributes.value(QWebSettings::SessionStorageEnabled,
    211                                     global->attributes.value(QWebSettings::SessionStorageEnabled));
    212         settings->setSessionStorageEnabled(value);
    213209    } else {
    214210        QList<QWebSettingsPrivate*> settings = *::allSettings();
     
    352348        local storage feature is enabled or not. Disabled by default.
    353349    \value LocalContentCanAccessRemoteUrls Specifies whether locally loaded documents are allowed to access remote urls.
    354     \value SessionStorageEnabled Specifies whether support for the HTML 5
    355         session storage feature is enabled or not. Enabled by default.               
    356350*/
    357351
     
    384378    d->attributes.insert(QWebSettings::LocalStorageEnabled, false);
    385379    d->attributes.insert(QWebSettings::LocalContentCanAccessRemoteUrls, false);
    386     d->attributes.insert(QWebSettings::SessionStorageEnabled, true);
    387380    d->offlineStorageDefaultQuota = 5 * 1024 * 1024;
    388381    d->defaultTextEncoding = QLatin1String("iso-8859-1");
  • trunk/WebKit/qt/Api/qwebsettings.h

    r50456 r50659  
    6868#endif
    6969        LocalContentCanAccessRemoteUrls,
    70         SessionStorageEnabled,
    7170        DnsPrefetchEnabled
    7271    };
  • trunk/WebKit/qt/ChangeLog

    r50656 r50659  
     12009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
     2
     3        Reviewed by Kenneth Christiansen.
     4
     5        [Qt] Remove the sessionStorage setting (per Page)
     6        https://bugs.webkit.org/show_bug.cgi?id=31249
     7
     8        This setting allows to run sessionStorage on/off on a per page
     9        basis. Remove this prematurely exposed API.
     10
     11        * Api/qwebsettings.cpp:
     12        (QWebSettingsPrivate::apply):
     13        (QWebSettings::QWebSettings):
     14        * tests/qwebpage/tst_qwebpage.cpp:
     15        (tst_QWebPage::database):
     16        (tst_QWebPage::testOptionalJSObjects):
     17
    1182009-11-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
    219
  • trunk/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

    r50556 r50659  
    457457
    458458    m_page->settings()->setAttribute(QWebSettings::LocalStorageEnabled, true);
    459     m_page->settings()->setAttribute(QWebSettings::SessionStorageEnabled, true);
    460459    m_page->settings()->setAttribute(QWebSettings::OfflineStorageDatabaseEnabled, true);
    461460
     
    15061505    QCOMPARE(testFlag(webPage1, QWebSettings::LocalStorageEnabled, "localStorage", false), false);
    15071506    QCOMPARE(testFlag(webPage2, QWebSettings::LocalStorageEnabled, "localStorage", false), true);
    1508 
    1509     QCOMPARE(testFlag(webPage1, QWebSettings::SessionStorageEnabled, "sessionStorage", false), false);
    1510     QCOMPARE(testFlag(webPage2, QWebSettings::SessionStorageEnabled, "sessionStorage", true),  true);
    1511     QCOMPARE(testFlag(webPage1, QWebSettings::SessionStorageEnabled, "sessionStorage", false), false);
    1512     QCOMPARE(testFlag(webPage2, QWebSettings::SessionStorageEnabled, "sessionStorage", false), true);
    15131507}
    15141508
Note: See TracChangeset for help on using the changeset viewer.