Changeset 50663 in webkit


Ignore:
Timestamp:
Nov 9, 2009 9:37:19 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-09 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
https://bugs.webkit.org/show_bug.cgi?id=31252

Route F1-F12 keypresses in the Console view to the current panel if there is one.

Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._promptKeyDown):
  • inspector/front-end/utilities.js: ():
  • manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
Location:
trunk/WebCore
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r50662 r50663  
     12009-11-09  Alexander Pavlov  <apavlov@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
     6        https://bugs.webkit.org/show_bug.cgi?id=31252
     7
     8        Route F1-F12 keypresses in the Console view to the current panel if there is one.
     9
     10        Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
     11
     12        * inspector/front-end/ConsoleView.js:
     13        (WebInspector.ConsoleView.prototype._promptKeyDown):
     14        * inspector/front-end/utilities.js:
     15        ():
     16        * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
     17
    1182009-11-09  Yael Aharon  <yael.aharon@nokia.com>
    219
  • trunk/WebCore/inspector/front-end/ConsoleView.js

    r50084 r50663  
    396396            return;
    397397        }
     398        if (isFnKey(event)) {
     399            if (WebInspector.currentPanel && WebInspector.currentPanel.handleKeyEvent) {
     400                WebInspector.currentPanel.handleKeyEvent(event);
     401                return;
     402            }
     403        }
    398404
    399405        this.prompt.handleKeyEvent(event);
  • trunk/WebCore/inspector/front-end/utilities.js

    r50564 r50663  
    822822    return event.keyCode !== 229 && event.keyIdentifier === "Enter";
    823823}
     824
     825function isFnKey(event) {
     826    return event.keyCode >= 112 && event.keyCode <= 123;
     827}
Note: See TracChangeset for help on using the changeset viewer.