Changeset 50673 in webkit


Ignore:
Timestamp:
Nov 9, 2009 11:43:17 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-09 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

showTree(CounterNode*) generates too little info and has too many spaces.
https://bugs.webkit.org/show_bug.cgi?id=31212

No new tests as the change has no functional effect it is just for
improved debugging.

  • rendering/CounterNode.cpp: (WebCore::showTreeAndMark): Changed to also show addresses of parent, next and previous siblings.
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r50672 r50673  
     12009-11-09  Carol Szabo  <carol.szabo@nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        showTree(CounterNode*) generates too little info and has too many spaces.
     6        https://bugs.webkit.org/show_bug.cgi?id=31212
     7
     8        No new tests as the change has no functional effect it is just for
     9        improved debugging.
     10
     11        * rendering/CounterNode.cpp:
     12        (WebCore::showTreeAndMark):
     13        Changed to also show addresses of parent, next and previous
     14        siblings.
     15
    1162009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
    217
  • trunk/WebCore/rendering/CounterNode.cpp

    r50583 r50673  
    170170        root = root->parent();
    171171
    172     for (const CounterNode* c = root; c; c = nextInPreOrder(c)) {
    173         if (c == node)
    174             fprintf(stderr, "*");
    175         for (const CounterNode* d = c; d && d != root; d = d->parent())
    176             fprintf(stderr, "\t");
    177         if (c->isReset())
    178             fprintf(stderr, "reset: %d %d\n", c->value(), c->countInParent());
    179         else
    180             fprintf(stderr, "increment: %d %d\n", c->value(), c->countInParent());
     172    for (const CounterNode* current = root; current; current = nextInPreOrder(current)) {
     173        fwrite((current == node) ? "*" : " ", 1, 1, stderr);
     174        for (const CounterNode* parent = current; parent && parent != root; parent = parent->parent())
     175            fwrite("  ", 1, 2, stderr);
     176        fprintf(stderr, "%p %s: %d %d P:%p PS:%p NS:%p R:%p\n",
     177            current, current->isReset() ? "reset____" : "increment", current->value(),
     178            current->countInParent(), current->parent(), current->previousSibling(),
     179            current->nextSibling(), current->renderer());
    181180    }
    182181}
Note: See TracChangeset for help on using the changeset viewer.