Changeset 50679 in webkit


Ignore:
Timestamp:
Nov 9, 2009 12:46:06 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
https://bugs.webkit.org/show_bug.cgi?id=31140

Test that XHR request can set http headers with no value.

  • http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html: Added.

2009-11-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
https://bugs.webkit.org/show_bug.cgi?id=31140

QtNetwork interprets null string as request to remove the header, not add it.
Replace null values with empty values before passing them to QtNetwork.

Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html

  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r50665 r50679  
     12009-11-09  Yael Aharon  <yael.aharon@nokia.com>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
     6        https://bugs.webkit.org/show_bug.cgi?id=31140
     7
     8        Test that XHR request can set http headers with no value.
     9
     10        * http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value-expected.txt: Added.
     11        * http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html: Added.
     12
    1132009-11-09  Mark Mentovai  <mark@chromium.org>
    214
  • trunk/WebCore/ChangeLog

    r50677 r50679  
     12009-11-09  Yael Aharon  <yael.aharon@nokia.com>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
     6        https://bugs.webkit.org/show_bug.cgi?id=31140
     7
     8        QtNetwork interprets null string as request to remove the header, not add it.
     9        Replace null values with empty values before passing them to QtNetwork.
     10
     11        Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
     12
     13        * platform/network/qt/ResourceRequestQt.cpp:
     14        (WebCore::ResourceRequest::toNetworkRequest):
     15
    1162009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
    217
  • trunk/WebCore/platform/network/qt/ResourceRequestQt.cpp

    r50454 r50679  
    4242        QByteArray name = QString(it->first).toAscii();
    4343        QByteArray value = QString(it->second).toAscii();
    44         request.setRawHeader(name, value);
     44        // QNetworkRequest::setRawHeader() would remove the header if the value is null
     45        // Make sure to set an empty header instead of null header.
     46        if (!value.isNull())
     47            request.setRawHeader(name, value);
     48        else
     49            request.setRawHeader(name, "");
    4550    }
    4651
Note: See TracChangeset for help on using the changeset viewer.