Changeset 50748 in webkit

Timestamp:

Nov 10, 2009 11:24:21 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-10 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for the part of loader directory in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=31161

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:

class Request - WebCore/loader/loader.cpp:100
struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
class ApplicationCacheHost - WebCore/loader/DocumentLoader.cpp:151
class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169

Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
MainThreadBridge is instantiated by 'new' in
WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.

ThreadableLoaderClient's inheriting has been changed to public.

• loader/ImageLoader.cpp:
• loader/ProgressTracker.cpp:
• loader/RedirectScheduler.cpp:
• loader/Request.h:
• loader/ThreadableLoaderClient.h:
• loader/WorkerThreadableLoader.h:
• loader/appcache/ApplicationCacheHost.h:
• loader/appcache/ApplicationCacheStorage.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/ImageLoader.cpp (modified) (1 diff)
• loader/ProgressTracker.cpp (modified) (1 diff)
• loader/RedirectScheduler.cpp (modified) (1 diff)
• loader/Request.h (modified) (1 diff)
• loader/ThreadableLoaderClient.h (modified) (1 diff)
• loader/WorkerThreadableLoader.h (modified) (1 diff)
• loader/appcache/ApplicationCacheHost.h (modified) (1 diff)
• loader/appcache/ApplicationCacheStorage.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Allow custom memory allocation control for the part of loader directory in WebCore
+        https://bugs.webkit.org/show_bug.cgi?id=31161
+
+        Inherits the following classes from Noncopyable because these are instantiated
+        by 'new' and these are no need to be copyable:
+
+        class Request - WebCore/loader/loader.cpp:100
+        struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
+        class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
+        class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
+        class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
+        struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
+
+        Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
+        MainThreadBridge is instantiated by 'new' in 
+        WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
+
+        ThreadableLoaderClient's inheriting has been changed to public.
+
+        * loader/ImageLoader.cpp:
+        * loader/ProgressTracker.cpp:
+        * loader/RedirectScheduler.cpp:
+        * loader/Request.h:
+        * loader/ThreadableLoaderClient.h:
+        * loader/WorkerThreadableLoader.h:
+        * loader/appcache/ApplicationCacheHost.h:
+        * loader/appcache/ApplicationCacheStorage.h:
+
 2009-11-10  Philippe Normand  <pnormand@igalia.com>
 

trunk/WebCore/loader/ImageLoader.cpp

@@ -32 +32 @@
 namespace WebCore {
 
-class ImageEventSender {
+class ImageEventSender : public Noncopyable {
 public:
     ImageEventSender(const AtomicString& eventType);

trunk/WebCore/loader/ProgressTracker.cpp

@@ -48 +48 @@
 static const int progressItemDefaultEstimatedLength = 1024 * 16;
 
-struct ProgressItem {
+struct ProgressItem : Noncopyable {
     ProgressItem(long long length) 
         : bytesReceived(0)

trunk/WebCore/loader/RedirectScheduler.cpp

@@ -45 +45 @@
 namespace WebCore {
 
-struct ScheduledRedirection {
+struct ScheduledRedirection : Noncopyable {
     enum Type { redirection, locationChange, historyNavigation, formSubmission };
 

trunk/WebCore/loader/Request.h

@@ -31 +31 @@
     class DocLoader;
 
-    class Request {
+    class Request : public Noncopyable {
     public:
         Request(DocLoader*, CachedResource*, bool incremental, bool skipCanLoadCheck, bool sendResourceLoadCallbacks);

trunk/WebCore/loader/ThreadableLoaderClient.h

@@ -37 +37 @@
     class ResourceResponse;
 
-    class ThreadableLoaderClient {
+    class ThreadableLoaderClient : public Noncopyable {
     public:
         virtual void didSendData(unsigned long long /*bytesSent*/, unsigned long long /*totalBytesToBeSent*/) { }

trunk/WebCore/loader/WorkerThreadableLoader.h

@@ -95 +95 @@
         //    done in createCallbackTask), so the ThreadableLoaderClientWrapper instance is there until all
         //    tasks are executed.
-        class MainThreadBridge : ThreadableLoaderClient {
+        class MainThreadBridge : public ThreadableLoaderClient {
         public:
             // All executed on the worker context's thread.

trunk/WebCore/loader/appcache/ApplicationCacheHost.h

@@ -58 +58 @@
 #endif
 
-    class ApplicationCacheHost {
+    class ApplicationCacheHost : public Noncopyable {
     public:
         // The Status numeric values are specified in the HTML5 spec.

trunk/WebCore/loader/appcache/ApplicationCacheStorage.h

@@ -45 +45 @@
 class StorageIDJournal;
 
-class ApplicationCacheStorage {
+class ApplicationCacheStorage : public Noncopyable {
 public:
     void setCacheDirectory(const String&);