Changeset 50754 in webkit

Timestamp:

Nov 10, 2009 12:52:57 PM (14 years ago)

Author:

jorlow@chromium.org

Message:

2009-11-09 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Eric Seidel.

Remove session storage setting
​https://bugs.webkit.org/show_bug.cgi?id=31279

Remove session storage from Settings. It was added temporarily so we could
disable it by default at runtime in Chromium. We now disable these things in a
different way, so it's time to remove it. Qt also depended on this setting for
a short period of time, but after talking to them we agreed that it should be
removed.

This bug is the second half of ​https://bugs.webkit.org/show_bug.cgi?id=30602

• page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage):
• page/Settings.cpp: (WebCore::Settings::Settings):
• page/Settings.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMWindow.cpp (modified) (1 diff)
• page/Settings.cpp (modified) (2 diffs)
• page/Settings.h (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Remove session storage setting
+        https://bugs.webkit.org/show_bug.cgi?id=31279
+
+        Remove session storage from Settings.  It was added temporarily so we could
+        disable it by default at runtime in Chromium.  We now disable these things in a
+        different way, so it's time to remove it.  Qt also depended on this setting for
+        a short period of time, but after talking to them we agreed that it should be
+        removed.
+
+        This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::sessionStorage):
+        * page/Settings.cpp:
+        (WebCore::Settings::Settings):
+        * page/Settings.h:
+
 2009-11-10  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/page/DOMWindow.cpp

@@ -575 +575 @@
         return 0;
 
-    if (!page->settings()->sessionStorageEnabled())
-        return 0;
-
     RefPtr<StorageArea> storageArea = page->sessionStorage()->storageArea(document->securityOrigin());
 #if ENABLE(INSPECTOR)

trunk/WebCore/page/Settings.cpp

@@ -73 +73 @@
     , m_databasesEnabled(false)
     , m_localStorageEnabled(false)
-    , m_sessionStorageEnabled(true)
     , m_isJavaScriptEnabled(false)
     , m_isWebSecurityEnabled(true)
@@ -257 +256 @@
 }
 
-void Settings::setSessionStorageEnabled(bool sessionStorageEnabled)
-{
-    m_sessionStorageEnabled = sessionStorageEnabled;
-}
-
 void Settings::setLocalStorageQuota(unsigned localStorageQuota)
 {

trunk/WebCore/page/Settings.h

@@ -125 +125 @@
         void setLocalStorageEnabled(bool);
         bool localStorageEnabled() const { return m_localStorageEnabled; }
-
-        void setSessionStorageEnabled(bool);
-        bool sessionStorageEnabled() const { return m_sessionStorageEnabled; }
 
         void setLocalStorageQuota(unsigned);
@@ -308 +305 @@
         bool m_databasesEnabled : 1;
         bool m_localStorageEnabled : 1;
-        bool m_sessionStorageEnabled : 1;
         bool m_isJavaScriptEnabled : 1;
         bool m_isWebSecurityEnabled : 1;