Changeset 50843 in webkit


Ignore:
Timestamp:
Nov 11, 2009 2:49:26 PM (14 years ago)
Author:
bweinstein@apple.com
Message:

WebCore: If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
because there is a CG bug preventing this from working.

Reviewed by Beth Dakin.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef):

LayoutTests: Unskip the webkit-color-correction tests because the workaround of using
the deviceRGBColorSpace allows the tests to pass on Windows.

Reviewed by Beth Dakin.

  • platform/win/Skipped:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r50841 r50843  
     12009-11-11  Brian Weinstein  <bweinstein@apple.com>
     2
     3        Reviewed by Beth Dakin.
     4
     5        Unskip the webkit-color-correction tests because the workaround of using
     6        the deviceRGBColorSpace allows the tests to pass on Windows.
     7
     8        * platform/win/Skipped:
     9
    1102009-11-11  Brian Weinstein  <bweinstein@apple.com>
    211

  • trunk/LayoutTests/platform/win/Skipped

    r50841 r50843  
    683683# Missing SocketStreamHandle implementation
    684684websocket/tests
    685 
    686 # https://bugs.webkit.org/show_bug.cgi?id=31363
    687 fast/css/color-correction-backgrounds-and-text.html
    688 fast/css/color-correction-on-backgrounds.html
    689 fast/css/color-correction-on-text.html
    690 fast/css/color-correction.html

  • trunk/WebCore/ChangeLog

    r50840 r50843  
     12009-11-11  Brian Weinstein  <bweinstein@apple.com>
     2
     3        Reviewed by Beth Dakin.
     4
     5        If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
     6        because there is a CG bug preventing this from working.
     7
     8        * platform/graphics/cg/GraphicsContextCG.cpp:
     9        (WebCore::sRGBColorSpaceRef):
     10
    1112009-11-11  Pavel Feldman  <pfeldman@chromium.org>
    212

  • trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

    r50776 r50843  
    7070static CGColorSpaceRef sRGBColorSpaceRef()
    7171{
    72 #ifdef BUILDING_ON_TIGER
     72    // FIXME: Windows should be able to use kCGColorSpaceSRGB, this is tracked by http://webkit.org/b/31363.
     73#if PLATFORM(WIN) || defined(BUILDING_ON_TIGER)
    7374    return deviceRGBColorSpaceRef();
    7475#else
Note: See TracChangeset for help on using the changeset viewer.