Changeset 50883 in webkit


Ignore:
Timestamp:
Nov 12, 2009 9:37:39 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-12 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

ARIA: add alert type roles
​https://bugs.webkit.org/show_bug.cgi?id=31392

  • platform/mac/accessibility/aria-alerts-expected.txt: Added.
  • platform/mac/accessibility/aria-alerts.html: Added.

2009-11-12 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

ARIA: add alert type roles
​https://bugs.webkit.org/show_bug.cgi?id=31392

Test: platform/mac/accessibility/aria-alerts.html

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

2009-11-12 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

ARIA: add alert type roles
​https://bugs.webkit.org/show_bug.cgi?id=31392

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt:

2009-11-12 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

ARIA: add alert type roles
​https://bugs.webkit.org/show_bug.cgi?id=31392

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXARIAContentGroupText:]):
Location:
trunk
Files:
2 added
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r50878 r50883  
     12009-11-12  Chris Fleizach  <cfleizach@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        ARIA: add alert type roles
     6        https://bugs.webkit.org/show_bug.cgi?id=31392
     7
     8        * platform/mac/accessibility/aria-alerts-expected.txt: Added.
     9        * platform/mac/accessibility/aria-alerts.html: Added.
     10
    1112009-11-12  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
    212

  • trunk/WebCore/ChangeLog

    r50882 r50883  
     12009-11-12  Chris Fleizach  <cfleizach@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        ARIA: add alert type roles
     6        https://bugs.webkit.org/show_bug.cgi?id=31392
     7
     8        Test: platform/mac/accessibility/aria-alerts.html
     9
     10        * accessibility/AccessibilityObject.h:
     11        * accessibility/AccessibilityRenderObject.cpp:
     12        * accessibility/mac/AccessibilityObjectWrapper.mm:
     13
    1142009-11-11  Alexey Proskuryakov  <ap@apple.com>
    215

  • trunk/WebCore/accessibility/AccessibilityObject.h

    r50865 r50883  
    177177    LandmarkSearchRole,
    178178   
     179    ApplicationAlertRole,
     180    ApplicationAlertDialogRole,
     181    ApplicationDialogRole,
    179182    ApplicationLogRole,
    180183    ApplicationMarqueeRole,

  • trunk/WebCore/accessibility/AccessibilityRenderObject.cpp

    r50865 r50883  
    24332433{
    24342434    const RoleEntry roles[] = {
     2435        { "alert", ApplicationAlertRole },
     2436        { "alertdialog", ApplicationAlertDialogRole },
    24352437        { "application", LandmarkApplicationRole },
    24362438        { "article", DocumentArticleRole },
    … …  
    24402442        { "complementary", LandmarkComplementaryRole },
    24412443        { "contentinfo", LandmarkContentInfoRole },
     2444        { "dialog", ApplicationDialogRole },
    24422445        { "grid", TableRole },
    24432446        { "gridcell", CellRole },

  • trunk/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm

    r50865 r50883  
    10381038        { LandmarkNavigationRole, NSAccessibilityGroupRole },
    10391039        { LandmarkSearchRole, NSAccessibilityGroupRole },
     1040        { ApplicationAlertRole, NSAccessibilityGroupRole },
     1041        { ApplicationAlertDialogRole, NSAccessibilityGroupRole },
     1042        { ApplicationDialogRole, NSAccessibilityGroupRole },
    10401043        { ApplicationLogRole, NSAccessibilityGroupRole },
    10411044        { ApplicationMarqueeRole, NSAccessibilityGroupRole },
    … …  
    11171120        case LandmarkSearchRole:
    11181121            return @"AXLandmarkSearch";
     1122        case ApplicationAlertRole:
     1123            return @"AXApplicationAlert";
     1124        case ApplicationAlertDialogRole:
     1125            return @"AXApplicationAlertDialog";
     1126        case ApplicationDialogRole:
     1127            return @"AXApplicationDialog";
    11191128        case ApplicationLogRole:
    11201129            return @"AXApplicationLog";
    … …  
    11781187            case LandmarkSearchRole:
    11791188                return AXARIAContentGroupText(@"ARIALandmarkSearch");
     1189            case ApplicationAlertRole:
     1190                return AXARIAContentGroupText(@"ARIAApplicationAlert");
     1191            case ApplicationAlertDialogRole:
     1192                return AXARIAContentGroupText(@"ARIAApplicationAlertDialog");
     1193            case ApplicationDialogRole:
     1194                return AXARIAContentGroupText(@"ARIAApplicationDialog");
    11801195            case ApplicationLogRole:
    11811196                return AXARIAContentGroupText(@"ARIAApplicationLog");

  • trunk/WebKit/ChangeLog

    r50429 r50883  
     12009-11-12  Chris Fleizach  <cfleizach@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        ARIA: add alert type roles
     6        https://bugs.webkit.org/show_bug.cgi?id=31392
     7
     8        * English.lproj/Localizable.strings:
     9        * StringsNotToBeLocalized.txt:
     10
    1112009-11-02  Eric Carlson  <eric.carlson@apple.com>
    212

  • trunk/WebKit/English.lproj/Localizable.strings

    r50429 r50883  
    458458"activate" = "activate";
    459459
     460/* An ARIA accessibility group that acts as an alert. */
     461"alert" = "alert";
     462
     463/* An ARIA accessibility group that acts as an alert dialog. */
     464"alert dialog" = "alert dialog";
     465
    460466/* An ARIA accessibility group that acts as an application. */
    461467"application" = "application";
    … …  
    518524"definition" = "definition";
    519525
     526/* An ARIA accessibility group that acts as an dialog. */
     527"dialog" = "dialog";
     528
    520529/* An ARIA accessibility group that acts as a document. */
    521530"document" = "document";
    … …  
    725734"switching protocols" = "switching protocols";
    726735
     736/* An ARIA accessibility group that contenst the content of a tab. */
     737"tab panel" = "tab panel";
     738
    727739/* HTTP result code string */
    728740"temporarily redirected" = "temporarily redirected";

  • trunk/WebKit/StringsNotToBeLocalized.txt

    r50409 r50883  
    9797"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+-."
    9898"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+.-"
     99"ARIAApplicationAlert"
     100"ARIAApplicationAlertDialog"
     101"ARIAApplicationDialog"
    99102"ARIAApplicationLog"
    100103"ARIAApplicationMarquee"

  • trunk/WebKit/mac/ChangeLog

    r50786 r50883  
     12009-11-12  Chris Fleizach  <cfleizach@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        ARIA: add alert type roles
     6        https://bugs.webkit.org/show_bug.cgi?id=31392
     7
     8        * WebCoreSupport/WebViewFactory.mm:
     9        (-[WebViewFactory AXARIAContentGroupText:]):
     10
    1112009-11-10  Daniel Bates  <dbates@webkit.org>
    212

  • trunk/WebKit/mac/WebCoreSupport/WebViewFactory.mm

    r50429 r50883  
    556556- (NSString *)AXARIAContentGroupText:(NSString *)ariaType
    557557{
     558    if ([ariaType isEqualToString:@"ARIAApplicationAlert"])
     559        return UI_STRING("alert", "An ARIA accessibility group that acts as an alert.");
     560    if ([ariaType isEqualToString:@"ARIAApplicationAlertDialog"])
     561        return UI_STRING("alert dialog", "An ARIA accessibility group that acts as an alert dialog.");
     562    if ([ariaType isEqualToString:@"ARIAApplicationDialog"])
     563        return UI_STRING("dialog", "An ARIA accessibility group that acts as an dialog.");
    558564    if ([ariaType isEqualToString:@"ARIAApplicationLog"])
    559565        return UI_STRING("log", "An ARIA accessibility group that acts as a console log.");
Note: See TracChangeset for help on using the changeset viewer.