Changeset 50885 in webkit

Timestamp:

Nov 12, 2009 10:23:56 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2009-11-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Minor timeline fixes.

​https://bugs.webkit.org/show_bug.cgi?id=31417

• inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineRecordTreeElement.prototype._updateDetails): (WebInspector.TimelineRecordTreeElement.prototype.refresh):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelinePanel.js (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Web Inspector: Minor timeline fixes.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31417
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._getRecordDetails):
+        (WebInspector.TimelineRecordTreeElement.prototype.onattach):
+        (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
+        (WebInspector.TimelineRecordTreeElement.prototype.refresh):
+
 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
 

trunk/WebCore/inspector/front-end/TimelinePanel.js

@@ -211 +211 @@
         case WebInspector.TimelineAgent.RecordType.ResourceReceiveResponse:
         case WebInspector.TimelineAgent.RecordType.ResourceFinish:
-            return WebInspector.displayNameForURL(this._sendRequestRecords[record.data.identifier].data.url);
+            var sendRequestRecord = this._sendRequestRecords[record.data.identifier];
+            return sendRequestRecord ? WebInspector.displayNameForURL(sendRequestRecord.data.url) : "";
         case WebInspector.TimelineAgent.RecordType.MarkTimeline:
             return record.data.message;
@@ -533 +534 @@
             this.dataElement = document.createElement("span");
             this.dataElement.className = "data dimmed";
-            this.dataElement.textContent = "(" + this._record.details + ")";
-            this.dataElement.title = this._record.details;
+            this._updateDetails();
 
             this.listItemElement.appendChild(separatorElement);
@@ -541 +541 @@
     },
 
+    _updateDetails: function() {
+        if (this.dataElement && this._record.details !== this._details) {
+            this._details = this._record.details;
+            this.dataElement.textContent = "(" + this._details + ")";
+            this.dataElement.title = this._details;
+        }
+    },
+
     refresh: function()
     {
-        if (this._record.details) {
-            this.dataElement.textContent = "(" + this._record.details + ")";
-            this.dataElement.title = this._record.details;
-        }
+        this._updateDetails();
 
         if (this._record.count <= 1)