Changeset 50887 in webkit

Timestamp:

Nov 12, 2009 10:46:20 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-12 Nicolas Weber <​thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Send |keypress()| events for keys with cmd down, like safari.
Test: Hit cmd-shift-a on unixpapa.com/js/testkey.html , should show a
keypress() event.

• src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::keyboardEvent):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/mac/WebInputEventFactory.mm (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2009-11-12  Nicolas Weber  <thakis@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Send |keypress()| events for keys with cmd down, like safari.
+        Test: Hit cmd-shift-a on unixpapa.com/js/testkey.html , should show a
+        keypress() event.
+
+        * src/mac/WebInputEventFactory.mm:
+        (WebKit::WebInputEventFactory::keyboardEvent):
+
 2009-11-11  Jeremy Orlow  <jorlow@chromium.org>
 

trunk/WebKit/chromium/src/mac/WebInputEventFactory.mm

@@ -948 +948 @@
     result.unmodifiedText[0] = character;
 
-    // Windows and Linux set |isSystemKey| if alt is down. WebKit looks at this
-    // flag to decide if it should handle a key or not. E.g. alt-left/right
-    // shouldn't be used by WebKit to scroll the current page, because we want
-    // to get that key back for it to do history navigation. Hence, the
-    // corresponding situation on OS X is to set this for cmd key presses.
-    if (result.modifiers & WebInputEvent::MetaKey)
-        result.isSystemKey = true;
+    // Do not set |isSystemKey| in this constructor. This constructor is used
+    // to build key events that eventually become js |keypress()| events, which
+    // do not fire if |isSystemKey| is set. Since we trigger shortcuts after
+    // |keydown()|, it is ok to not set this anyway.
 
     return result;