Changeset 50919 in webkit

Timestamp:

Nov 12, 2009 5:12:20 PM (14 years ago)

Author:

dimich@chromium.org

Message:

Add postTaskToMainThread to ScriptExecutionContext.
Move the code to post task to the main thread into a new method on ScriptExecutionContext,
to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
contexts that live on the main thread.
​https://bugs.webkit.org/show_bug.cgi?id=31427

Reviewed by Alexey Proskuryakov.

No new tests - simply moving the code.

• dom/Document.cpp:

(WebCore::Document::postTask):

• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskData::PerformTaskData):
(WebCore::PerformTaskData::performTask):
(WebCore::ScriptExecutionContext::postTaskToMainThread):

• dom/ScriptExecutionContext.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)
• dom/ScriptExecutionContext.cpp (modified) (1 diff)
• dom/ScriptExecutionContext.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-12  Dmitry Titov  <dimich@chromium.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Add postTaskToMainThread to ScriptExecutionContext.
+        Move the code to post task to the main thread into a new method on ScriptExecutionContext,
+        to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
+        contexts that live on the main thread.
+        https://bugs.webkit.org/show_bug.cgi?id=31427
+
+        No new tests - simply moving the code.
+
+        * dom/Document.cpp:
+        (WebCore::Document::postTask):
+        * dom/ScriptExecutionContext.cpp:
+        (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
+        (WebCore::ScriptExecutionContextTaskTimer::fired):
+        (WebCore::PerformTaskData::PerformTaskData):
+        (WebCore::PerformTaskData::performTask):
+        (WebCore::ScriptExecutionContext::postTaskToMainThread):
+        * dom/ScriptExecutionContext.h:
+
 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/dom/Document.cpp

@@ -4537 +4537 @@
 }
 
-class ScriptExecutionContextTaskTimer : public TimerBase {
-public:
-    ScriptExecutionContextTaskTimer(PassRefPtr<Document> context, PassOwnPtr<ScriptExecutionContext::Task> task)
-        : m_context(context)
-        , m_task(task)
-    {
-    }
-
-private:
-    virtual void fired()
-    {
-        m_task->performTask(m_context.get());
-        delete this;
-    }
-
-    RefPtr<Document> m_context;
-    OwnPtr<ScriptExecutionContext::Task> m_task;
-};
-
-struct PerformTaskContext : Noncopyable {
-    PerformTaskContext(ScriptExecutionContext* scriptExecutionContext, PassOwnPtr<ScriptExecutionContext::Task> task)
-        : scriptExecutionContext(scriptExecutionContext)
-        , task(task)
-    {
-    }
-
-    ScriptExecutionContext* scriptExecutionContext; // The context should exist until task execution.
-    OwnPtr<ScriptExecutionContext::Task> task;
-};
-
-static void performTask(void* ctx)
-{
-    PerformTaskContext* ptctx = reinterpret_cast<PerformTaskContext*>(ctx);
-    ptctx->task->performTask(ptctx->scriptExecutionContext);
-    delete ptctx;
-}
-
 void Document::postTask(PassOwnPtr<Task> task)
 {
-    if (isMainThread()) {
-        ScriptExecutionContextTaskTimer* timer = new ScriptExecutionContextTaskTimer(static_cast<Document*>(this), task);
-        timer->startOneShot(0);
-    } else {
-        callOnMainThread(performTask, new PerformTaskContext(this, task));
-    }
+    postTaskToMainThread(task);
 }
 

trunk/WebCore/dom/ScriptExecutionContext.cpp

@@ -216 +216 @@
 #endif
 
+class ScriptExecutionContextTaskTimer : public TimerBase {
+public:
+    ScriptExecutionContextTaskTimer(PassRefPtr<ScriptExecutionContext> context, PassOwnPtr<ScriptExecutionContext::Task> task)
+        : m_context(context)
+        , m_task(task)
+    {
+    }
+
+private:
+    virtual void fired()
+    {
+        m_task->performTask(m_context.get());
+        delete this;
+    }
+
+    RefPtr<ScriptExecutionContext> m_context;
+    OwnPtr<ScriptExecutionContext::Task> m_task;
+};
+
+class PerformTaskData {
+public:
+    PerformTaskData(PassRefPtr<ScriptExecutionContext> context, PassOwnPtr<ScriptExecutionContext::Task> task)
+        : m_context(context)
+        , m_task(task)
+    {
+    }
+
+    static void performTask(void* data)
+    {
+        PerformTaskData* taskData = static_cast<PerformTaskData*>(data);
+        taskData->m_task->performTask(taskData->m_context.get());
+        delete taskData;
+    }
+
+private:
+    RefPtr<ScriptExecutionContext> m_context;
+    OwnPtr<ScriptExecutionContext::Task> m_task;
+};
+
+void ScriptExecutionContext::postTaskToMainThread(PassOwnPtr<Task> task)
+{
+    if (isMainThread()) {
+        ScriptExecutionContextTaskTimer* timer = new ScriptExecutionContextTaskTimer(this, task);
+        timer->startOneShot(0);
+    } else {
+        callOnMainThread(PerformTaskData::performTask, new PerformTaskData(this, task));
+    }
+}
+
 } // namespace WebCore

trunk/WebCore/dom/ScriptExecutionContext.h

@@ -115 +115 @@
         void setSecurityOrigin(PassRefPtr<SecurityOrigin>);
 
+        // Helper for contexts that live on the main thread.
+        void postTaskToMainThread(PassOwnPtr<Task>);
+
     private:
         virtual const KURL& virtualURL() const = 0;