Changeset 50921 in webkit


Ignore:
Timestamp:
Nov 12, 2009 5:59:51 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-12 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Gustavo Noronha Silva.

​https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument

Added testing support for AtkDocument implementation.

  • accessibility/document-attributes.html: Added.
  • accessibility/document-attributes-expected.txt: Added.
  • platform/mac/Skipped:
  • platform/win/Skipped:

2009-11-12 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Gustavo Noronha Silva.

​https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument

Added testing support.

  • DumpRenderTree/AccessibilityUIElement.cpp:
  • DumpRenderTree/AccessibilityUIElement.h: (getDocumentEncodingCallback): (getDocumentURICallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::documentEncoding): (AccessibilityUIElement::documentURI):
Location:
trunk
Files:
2 added
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r50920 r50921  
     12009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
     2
     3        Reviewed by Gustavo Noronha Silva.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=30997
     6        [Gtk] Implemment AtkDocument
     7
     8        Added testing support for AtkDocument implementation.
     9
     10        * accessibility/document-attributes.html: Added.
     11        * accessibility/document-attributes-expected.txt: Added.
     12        * platform/mac/Skipped:
     13        * platform/win/Skipped:
     14
    1152009-11-11  Dirk Schulze  <krit@webkit.org>
    216

  • trunk/LayoutTests/platform/mac/Skipped

    r50794 r50921  
    9999# Missing SocketStreamHandle implementation
    100100websocket/tests
     101
     102# Accessibility tests without results
     103accessibility/document-attributes.html

  • trunk/LayoutTests/platform/win/Skipped

    r50917 r50921  
    372372accessibility/button-press-action.html
    373373accessibility/canvas.html
     374accessibility/document-attributes.html
    374375accessibility/editable-webarea-context-menu-point.html
    375376accessibility/iframe-bastardization.html

  • trunk/WebKitTools/ChangeLog

    r50907 r50921  
     12009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
     2
     3        Reviewed by Gustavo Noronha Silva.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=30997
     6        [Gtk] Implemment AtkDocument
     7
     8        Added testing support.
     9
     10        * DumpRenderTree/AccessibilityUIElement.cpp:
     11        * DumpRenderTree/AccessibilityUIElement.h:
     12        (getDocumentEncodingCallback):
     13        (getDocumentURICallback):
     14        (AccessibilityUIElement::getJSClass):
     15        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
     16        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
     17        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
     18        (AccessibilityUIElement::documentEncoding):
     19        (AccessibilityUIElement::documentURI):
     20
    1212009-11-12  Adam Roben  <aroben@apple.com>
    222

  • trunk/WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp

    r50865 r50921  
    428428    JSRetainPtr<JSStringRef> accessibilityValue(Adopt, toAXElement(thisObject)->accessibilityValue());
    429429    return JSValueMakeString(context, accessibilityValue.get());
     430}
     431
     432static JSValueRef getDocumentEncodingCallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
     433{
     434    JSRetainPtr<JSStringRef> documentEncoding(Adopt, toAXElement(thisObject)->documentEncoding());
     435    return JSValueMakeString(context, documentEncoding.get());
     436}
     437
     438static JSValueRef getDocumentURICallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
     439{
     440    JSRetainPtr<JSStringRef> documentURI(Adopt, toAXElement(thisObject)->documentURI());
     441    return JSValueMakeString(context, documentURI.get());
    430442}
    431443
    … …  
    472484        { "valueDescription", getValueDescriptionCallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    473485        { "hierarchicalLevel", hierarchicalLevelCallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
     486        { "documentEncoding", getDocumentEncodingCallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
     487        { "documentURI", getDocumentURICallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    474488        { 0, 0, 0, 0 }
    475489    };

  • trunk/WebKitTools/DumpRenderTree/AccessibilityUIElement.h

    r50865 r50921  
    113113    double clickPointX();
    114114    double clickPointY();
     115    JSStringRef documentEncoding();
     116    JSStringRef documentURI();
    115117
    116118    // Table-specific attributes

  • trunk/WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

    r50865 r50921  
    477477    return JSStringCreateWithCharacters(0, 0);
    478478}
     479
     480JSStringRef AccessibilityUIElement::documentEncoding()
     481{
     482    AtkRole role = atk_object_get_role(ATK_OBJECT(m_element));
     483    if (role != ATK_ROLE_DOCUMENT_FRAME)
     484        return JSStringCreateWithCharacters(0, 0);
     485
     486    return JSStringCreateWithUTF8CString(atk_document_get_attribute_value(ATK_DOCUMENT(m_element), "Encoding"));
     487}
     488
     489JSStringRef AccessibilityUIElement::documentURI()
     490{
     491    AtkRole role = atk_object_get_role(ATK_OBJECT(m_element));
     492    if (role != ATK_ROLE_DOCUMENT_FRAME)
     493        return JSStringCreateWithCharacters(0, 0);
     494
     495    return JSStringCreateWithUTF8CString(atk_document_get_attribute_value(ATK_DOCUMENT(m_element), "URI"));
     496}

  • trunk/WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm

    r50865 r50921  
    640640    return JSStringCreateWithCharacters(0, 0);
    641641}
     642
     643JSStringRef AccessibilityUIElement::documentEncoding()
     644{
     645    return JSStringCreateWithCharacters(0, 0);
     646}
     647
     648JSStringRef AccessibilityUIElement::documentURI()
     649{
     650    return JSStringCreateWithCharacters(0, 0);
     651}

  • trunk/WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp

    r50865 r50921  
    432432    return JSStringCreateWithCharacters(value.data(), value.length());
    433433}
     434
     435
     436JSStringRef AccessibilityUIElement::documentEncoding()
     437{
     438    return JSStringCreateWithCharacters(0, 0);
     439}
     440
     441JSStringRef AccessibilityUIElement::documentURI()
     442{
     443    return JSStringCreateWithCharacters(0, 0);
     444}
Note: See TracChangeset for help on using the changeset viewer.