Changeset 50928 in webkit

Timestamp:

Nov 12, 2009 9:17:55 PM (14 years ago)

Author:

dumi@chromium.org

Message:

Renaming some parameters passed to DB-related methods to better
indicate their purpose.

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=31449

WebCore:

• platform/chromium/ChromiumBridge.h:

WebKit/chromium:

• public/WebKitClient.h:
• src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::databaseOpenFile):
(WebCore::ChromiumBridge::databaseDeleteFile):
(WebCore::ChromiumBridge::databaseGetFileAttributes):
(WebCore::ChromiumBridge::databaseGetFileSize):

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/chromium/ChromiumBridge.h (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/public/WebKitClient.h (modified) (1 diff)
• WebKit/chromium/src/ChromiumBridge.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Renaming some parameters passed to DB-related methods to better
+        indicate their purpose.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31449
+
+        * platform/chromium/ChromiumBridge.h:
+
 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/platform/chromium/ChromiumBridge.h

@@ -119 +119 @@
 #if ENABLE(DATABASE)
         // Returns a handle to the DB file and ooptionally a handle to its containing directory
-        static PlatformFileHandle databaseOpenFile(const String& fileName, int desiredFlags, PlatformFileHandle* dirHandle = 0);
+        static PlatformFileHandle databaseOpenFile(const String& vfsFleName, int desiredFlags, PlatformFileHandle* dirHandle = 0);
         // Returns a SQLite code (SQLITE_OK = 0, on success)
-        static int databaseDeleteFile(const String& fileName, bool syncDir = false);
+        static int databaseDeleteFile(const String& vfsFileName, bool syncDir = false);
         // Returns the attributes of the DB file
-        static long databaseGetFileAttributes(const String& fileName);
+        static long databaseGetFileAttributes(const String& vfsFileName);
         // Returns the size of the DB file
-        static long long databaseGetFileSize(const String& fileName);
+        static long long databaseGetFileSize(const String& vfsFileName);
 #endif
 

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Renaming some parameters passed to DB-related methods to better
+        indicate their purpose.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31449
+
+        * public/WebKitClient.h:
+        * src/ChromiumBridge.cpp:
+        (WebCore::ChromiumBridge::databaseOpenFile):
+        (WebCore::ChromiumBridge::databaseDeleteFile):
+        (WebCore::ChromiumBridge::databaseGetFileAttributes):
+        (WebCore::ChromiumBridge::databaseGetFileSize):
+
 2009-11-12  Adam Barth  <abarth>
 

trunk/WebKit/chromium/public/WebKitClient.h

@@ -138 +138 @@
     // a handle to the directory containing this file
     virtual FileHandle databaseOpenFile(
-        const WebString& fileName, int desiredFlags, FileHandle* dirHandle) = 0;
+        const WebString& vfsFileName, int desiredFlags, FileHandle* dirHandle) = 0;
 
     // Deletes a database file and returns the error code
-    virtual int databaseDeleteFile(const WebString& fileName, bool syncDir) = 0;
+    virtual int databaseDeleteFile(const WebString& vfsFileName, bool syncDir) = 0;
 
     // Returns the attributes of the given database file
-    virtual long databaseGetFileAttributes(const WebString& fileName) = 0;
+    virtual long databaseGetFileAttributes(const WebString& vfsFileName) = 0;
 
     // Returns the size of the given database file
-    virtual long long databaseGetFileSize(const WebString& fileName) = 0;
+    virtual long long databaseGetFileSize(const WebString& vfsFileName) = 0;
 
 

trunk/WebKit/chromium/src/ChromiumBridge.cpp

@@ -307 +307 @@
 
 #if ENABLE(DATABASE)
-PlatformFileHandle ChromiumBridge::databaseOpenFile(const String& fileName, int desiredFlags, PlatformFileHandle* dirHandle)
-{
-    return webKitClient()->databaseOpenFile(WebString(fileName), desiredFlags, dirHandle);
-}
-
-int ChromiumBridge::databaseDeleteFile(const String& fileName, bool syncDir)
-{
-    return webKitClient()->databaseDeleteFile(WebString(fileName), syncDir);
-}
-
-long ChromiumBridge::databaseGetFileAttributes(const String& fileName)
-{
-    return webKitClient()->databaseGetFileAttributes(WebString(fileName));
-}
-
-long long ChromiumBridge::databaseGetFileSize(const String& fileName)
-{
-    return webKitClient()->databaseGetFileSize(WebString(fileName));
+PlatformFileHandle ChromiumBridge::databaseOpenFile(const String& vfsFileName, int desiredFlags, PlatformFileHandle* dirHandle)
+{
+    return webKitClient()->databaseOpenFile(WebString(vfsFileName), desiredFlags, dirHandle);
+}
+
+int ChromiumBridge::databaseDeleteFile(const String& vfsFileName, bool syncDir)
+{
+    return webKitClient()->databaseDeleteFile(WebString(vfsFileName), syncDir);
+}
+
+long ChromiumBridge::databaseGetFileAttributes(const String& vfsFileName)
+{
+    return webKitClient()->databaseGetFileAttributes(WebString(vfsFileName));
+}
+
+long long ChromiumBridge::databaseGetFileSize(const String& vfsFileName)
+{
+    return webKitClient()->databaseGetFileSize(WebString(vfsFileName));
 }
 #endif