Changeset 50933 in webkit


Ignore:
Timestamp:
Nov 13, 2009 1:51:49 AM (14 years ago)
Author:
pfeldman@chromium.org
Message:

2009-11-13 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Enable 'console.profile()' and 'console.profileEnd()'
regardless of JAVASCRIPT_DEBUGGER.

https://bugs.webkit.org/show_bug.cgi?id=31293

  • WebCore.gypi:
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profile): (WebCore::JSConsole::profileEnd):
  • bindings/v8/custom/V8ConsoleCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8CustomBinding.h:
  • page/Console.idl:
Location:
trunk/WebCore
Files:
1 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r50932 r50933  
     12009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Enable 'console.profile()' and 'console.profileEnd()'
     6        regardless of JAVASCRIPT_DEBUGGER.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=31293
     9
     10        * WebCore.gypi:
     11        * bindings/js/JSConsoleCustom.cpp:
     12        (WebCore::JSConsole::profile):
     13        (WebCore::JSConsole::profileEnd):
     14        * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
     15        (WebCore::CALLBACK_FUNC_DECL):
     16        * bindings/v8/custom/V8CustomBinding.h:
     17        * page/Console.idl:
     18
    1192009-11-12  David Levin  <levin@chromium.org>
    220
  • trunk/WebCore/WebCore.gypi

    r50772 r50933  
    650650            'bindings/v8/custom/V8ClipboardCustom.cpp',
    651651            'bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp',
     652            'bindings/v8/custom/V8ConsoleCustom.cpp',
    652653            'bindings/v8/custom/V8CustomBinding.cpp',
    653654            'bindings/v8/custom/V8CustomBinding.h',
  • trunk/WebCore/bindings/js/JSConsoleCustom.cpp

    r43122 r50933  
    2727#include "JSConsole.h"
    2828#include "JavaScriptProfile.h"
     29#include "ScriptCallStack.h"
    2930#include <runtime/JSArray.h>
    3031
     
    5152}
    5253
     54JSValue JSConsole::profile(ExecState* exec, const ArgList& args)
     55{
     56    ScriptCallStack callStack(exec, args, 1);
     57    const UString title = valueToStringWithUndefinedOrNullCheck(exec, args.at(0));
     58    impl()->profile(title, &callStack);
     59    return jsUndefined();
     60}
     61
     62JSValue JSConsole::profileEnd(ExecState* exec, const ArgList& args)
     63{
     64    ScriptCallStack callStack(exec, args, 1);
     65    const UString title = valueToStringWithUndefinedOrNullCheck(exec, args.at(0));
     66    impl()->profileEnd(title, &callStack);
     67    return jsUndefined();
     68}
     69
    5370#endif
    5471
  • trunk/WebCore/bindings/v8/custom/V8CustomBinding.h

    r50725 r50933  
    494494        DECLARE_CALLBACK(InspectorBackendWrapCallback);
    495495
     496        DECLARE_CALLBACK(ConsoleProfile);
     497        DECLARE_CALLBACK(ConsoleProfileEnd);
     498
    496499        DECLARE_CALLBACK(NodeIteratorNextNode);
    497500        DECLARE_CALLBACK(NodeIteratorPreviousNode);
  • trunk/WebCore/page/Console.idl

    r50501 r50933  
    5151#endif
    5252
    53 #if defined(ENABLE_JAVASCRIPT_DEBUGGER) && ENABLE_JAVASCRIPT_DEBUGGER
    54         [CustomArgumentHandling] void profile(in [ConvertUndefinedOrNullToNullString] DOMString title);
    55         [CustomArgumentHandling] void profileEnd(in [ConvertUndefinedOrNullToNullString] DOMString title);
    56 #endif
     53        [Custom] void profile(in [ConvertUndefinedOrNullToNullString] DOMString title);
     54        [Custom] void profileEnd(in [ConvertUndefinedOrNullToNullString] DOMString title);
    5755
    5856        void time(in [ConvertUndefinedOrNullToNullString] DOMString title);
Note: See TracChangeset for help on using the changeset viewer.