Changeset 50976 in webkit

Timestamp:

Nov 13, 2009 4:07:03 PM (14 years ago)

Author:

hamaji@chromium.org

Message:

2009-11-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

WebCore::externalRepresentation should update layout before getting render object
​https://bugs.webkit.org/show_bug.cgi?id=31459

Before this change, the render tree output for this test was wrong.
Note that #FF0000 (red) becomes #008000 (green) now.

• platform/mac/svg/custom/gradient-stop-style-change-expected.txt:

2009-11-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

WebCore::externalRepresentation should update layout before getting render object
​https://bugs.webkit.org/show_bug.cgi?id=31459

• rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/custom/gradient-stop-style-change-expected.txt (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderTreeAsText.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        WebCore::externalRepresentation should update layout before getting render object
+        https://bugs.webkit.org/show_bug.cgi?id=31459
+
+        Before this change, the render tree output for this test was wrong.
+        Note that #FF0000 (red) becomes #008000 (green) now.
+
+        * platform/mac/svg/custom/gradient-stop-style-change-expected.txt:
+
 2009-11-04  Adam Roben  <aroben@apple.com>
 

trunk/LayoutTests/platform/mac/svg/custom/gradient-stop-style-change-expected.txt

@@ -1 @@
-KRenderingPaintServer {id="test" [type=LINEAR-GRADIENT] [stops=[(0.00,#FF0000)]] [start=(0,0)] [end=(1,0)]}
+KRenderingPaintServer {id="test" [type=LINEAR-GRADIENT] [stops=[(0.00,#008000)]] [start=(0,0)] [end=(1,0)]}
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        WebCore::externalRepresentation should update layout before getting render object
+        https://bugs.webkit.org/show_bug.cgi?id=31459
+
+        * rendering/RenderTreeAsText.cpp:
+        (WebCore::externalRepresentation):
+
 2009-11-13  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/rendering/RenderTreeAsText.cpp

@@ -542 +542 @@
 String externalRepresentation(Frame* frame)
 {
+    frame->document()->updateLayout();
+
     RenderObject* o = frame->contentRenderer();
     if (!o)
@@ -550 +552 @@
     writeRenderResources(ts, o->document());
 #endif
-    if (o->view()->frameView())
-        o->view()->frameView()->layout();
     if (o->hasLayer()) {
         RenderLayer* l = toRenderBox(o)->layer();