Changeset 51018 in webkit

Timestamp:

Nov 16, 2009 1:25:03 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Unit test WorkQueue
​https://bugs.webkit.org/show_bug.cgi?id=31531

Adds basic unit testing for WorkQueue. Just runs through one cycle.

• Scripts/bugzilla-tool:
• Scripts/modules/statusbot.py:
• Scripts/modules/workqueue.py:
• Scripts/modules/workqueue_unittest.py: Added.
• Scripts/run-webkit-unittests:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/bugzilla-tool (modified) (1 diff)
• Scripts/modules/statusbot.py (modified) (1 diff)
• Scripts/modules/workqueue.py (modified) (3 diffs)
• Scripts/modules/workqueue_unittest.py (added)
• Scripts/run-webkit-unittests (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-16  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Unit test WorkQueue
+        https://bugs.webkit.org/show_bug.cgi?id=31531
+
+        Adds basic unit testing for WorkQueue.  Just runs through one cycle.
+
+        * Scripts/bugzilla-tool:
+        * Scripts/modules/statusbot.py:
+        * Scripts/modules/workqueue.py:
+        * Scripts/modules/workqueue_unittest.py: Added.
+        * Scripts/run-webkit-unittests:
+
 2009-11-16  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/bugzilla-tool

@@ -723 +723 @@
         log("Running WebKit Commit Queue. %s" % datetime.now().strftime(WorkQueue.log_date_format))
 
+    def should_continue_work_queue(self):
+        return True
+
     def next_work_item(self):
         # Fetch patches instead of just bug ids to that we validate reviewer/committer flags on every patch.

trunk/WebKitTools/Scripts/modules/statusbot.py

@@ -57 +57 @@
 
     def update_status(self, status, bug_id=None, patch_id=None):
+        # During unit testing, statusbot_host is None
+        if not self.statusbot_host:
+            return
         self.browser.open(self.update_status_url)
         self.browser.select_form(name="update_status")

trunk/WebKitTools/Scripts/modules/workqueue.py

@@ -34 +34 @@
 from datetime import datetime, timedelta
 
-from logging import log, OutputTee
-from scm import ScriptError
-from statusbot import StatusBot
+from modules.logging import log, OutputTee
+from modules.scm import ScriptError
+from modules.statusbot import StatusBot
 
 class WorkQueueDelegate:
@@ -49 +49 @@
 
     def begin_work_queue(self):
+        raise NotImplementedError, "subclasses must implement"
+
+    def should_continue_work_queue(self):
         raise NotImplementedError, "subclasses must implement"
 
@@ -79 +82 @@
 
         self._delegate.begin_work_queue()
-        while (True):
+        while (self._delegate.should_continue_work_queue()):
             self._ensure_work_log_closed()
             try:

trunk/WebKitTools/Scripts/run-webkit-unittests

@@ -38 +38 @@
 from modules.logging_unittest import *
 from modules.scm_unittest import *
+from modules.workqueue_unittest import *
 
 if __name__ == "__main__":