Changeset 51022 in webkit

Timestamp:

Nov 16, 2009 3:00:24 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

land-patches needs to be re-factored into smaller chunks
​https://bugs.webkit.org/show_bug.cgi?id=31532

• Scripts/bugzilla-tool: fix a couple obvious typos.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/bugzilla-tool (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-16  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        land-patches needs to be re-factored into smaller chunks
+        https://bugs.webkit.org/show_bug.cgi?id=31532
+
+        * Scripts/bugzilla-tool: fix a couple obvious typos.
+
 2009-11-16  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/bugzilla-tool

@@ -383 +383 @@
 
     @classmethod
-    def _close_bug_if_no_active_patches(cls, patch, option, tool):
+    def _close_bug_if_no_active_patches(cls, bugs, bug_id):
         # This should check to make sure there are no r? or r+ patches on the bug before closing.
         # https://bugs.webkit.org/show_bug.cgi?id=28230
-        tool.bugs.close_bug_as_fixed(bug_id, "All reviewed patches have been landed.  Closing bug.")
+        bugs.close_bug_as_fixed(bug_id, "All reviewed patches have been landed.  Closing bug.")
 
     @classmethod
@@ -406 +406 @@
                 cls._land_patch(patch, options, tool)
             if options.close_bug and patches:
-                cls._close_bug_if_no_active_patches(patches[0]['bug_id'])
+                cls._close_bug_if_no_active_patches(tool.bugs, patches[0]['bug_id'])
         except CheckoutNeedsUpdate, e:
             log("Commit failed because the checkout is out of date.  Please update and try again.")