Changeset 51027 in webkit

Timestamp:

Nov 16, 2009 3:54:21 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement PatchCollection
​https://bugs.webkit.org/show_bug.cgi?id=31541

This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.

• Scripts/modules/patchcollection.py: Added.
• Scripts/modules/patchcollection_unittest.py: Added.
• Scripts/run-webkit-unittests:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/bugzilla-tool (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ -12 +12 @@
         * Scripts/modules/patchcollection_unittest.py: Added.
         * Scripts/run-webkit-unittests:
+
+2009-11-16  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        bugzilla-tool land-patches will close bugs with patches r=?
+        https://bugs.webkit.org/show_bug.cgi?id=28230
+
+        The commit-queue shouldn't close patches with outstanding reviews on them,
+        even if many reviewers seem to be against multi-patch bugs.
+
+        * Scripts/bugzilla-tool:
 
 2009-11-16  Eric Seidel  <eric@webkit.org>

trunk/WebKitTools/Scripts/bugzilla-tool

@@ -378 +378 @@
     @classmethod
     def _close_bug_if_no_active_patches(cls, bugs, bug_id):
-        # This should check to make sure there are no r? or r+ patches on the bug before closing.
-        # https://bugs.webkit.org/show_bug.cgi?id=28230
+        # Check to make sure there are no r? or r+ patches on the bug before closing.
+        # Assume that r- patches are just previous patches someone forgot to obsolete.
+        patches = bugs.fetch_patches_from_bug(bug_id)
+        for patch in patches:
+            review_flag = patch.get('review')
+            if review_flag == '?' or review_flag == '+':
+                log("Not closing bug %s as attachment %s has review=%s.  Assuming there are more patches to land from this bug." % (patch['bug_id'], patch['id'], review_flag))
+                return
         bugs.close_bug_as_fixed(bug_id, "All reviewed patches have been landed.  Closing bug.")