Changeset 51070 in webkit


Ignore:
Timestamp:
Nov 17, 2009 1:36:45 AM (14 years ago)
Author:
hamaji@chromium.org
Message:

2009-11-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Eric Seidel.

Fix http tests so that they do not submit a GET form to about:blank.

Original tests expected that submitting an empty form to <about:blank> navigates
the browser to <about:blank?>, not <about:blank>. However, some other browsers
do not act like Safari, and in fact the layout test runner of Chromium was
failing to run these tests.

Prior to this patch, a test that only checks this behavior was added, so now
we can remove the dependency on it from these tests.

Some HTTP tests submit a GET form to about:blank
​https://bugs.webkit.org/show_bug.cgi?id=30423

  • http/tests/navigation/onload-navigation-iframe-2-expected.txt:
  • http/tests/navigation/onload-navigation-iframe-2.html:
  • http/tests/navigation/onload-navigation-iframe-expected.txt:
  • http/tests/navigation/onload-navigation-iframe-timeout-expected.txt:
  • http/tests/navigation/onload-navigation-iframe-timeout.html:
  • http/tests/navigation/onload-navigation-iframe.html:
  • http/tests/navigation/resources/blank.txt: Added.
Location:
trunk/LayoutTests
Files:
1 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r51069 r51070  
     12009-11-17  Yuta Kitamura  <yutak@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Fix http tests so that they do not submit a GET form to about:blank.
     6       
     7        Original tests expected that submitting an empty form to <about:blank> navigates
     8        the browser to <about:blank?>, not <about:blank>. However, some other browsers
     9        do not act like Safari, and in fact the layout test runner of Chromium was
     10        failing to run these tests.
     11       
     12        Prior to this patch, a test that only checks this behavior was added, so now
     13        we can remove the dependency on it from these tests.
     14
     15        Some HTTP tests submit a GET form to about:blank
     16        https://bugs.webkit.org/show_bug.cgi?id=30423
     17
     18        * http/tests/navigation/onload-navigation-iframe-2-expected.txt:
     19        * http/tests/navigation/onload-navigation-iframe-2.html:
     20        * http/tests/navigation/onload-navigation-iframe-expected.txt:
     21        * http/tests/navigation/onload-navigation-iframe-timeout-expected.txt:
     22        * http/tests/navigation/onload-navigation-iframe-timeout.html:
     23        * http/tests/navigation/onload-navigation-iframe.html:
     24        * http/tests/navigation/resources/blank.txt: Added.
     25
    1262009-11-17  Yuta Kitamura  <yutak@chromium.org>
    227

  • trunk/LayoutTests/http/tests/navigation/onload-navigation-iframe-2-expected.txt

    r42192 r51070  
    33============== Back Forward List ==============
    44curr->  http://127.0.0.1:8000/navigation/onload-navigation-iframe-2.html  **nav target**
    5             about:blank? (in frame "myFrame")
     5            http://127.0.0.1:8000/navigation/resources/blank.txt? (in frame "myFrame")
    66===============================================

  • trunk/LayoutTests/http/tests/navigation/onload-navigation-iframe-2.html

    r42192 r51070  
    2525</head>
    2626<body onload="runTest();">
    27 <form id="myForm" target="myFrame" action="about:blank" method="get">
     27<form id="myForm" target="myFrame" action="resources/blank.txt" method="get">
    2828</form>
    2929In this case, Safari and Firefox don't add a history item.

  • trunk/LayoutTests/http/tests/navigation/onload-navigation-iframe-expected.txt

    r25410 r51070  
    44============== Back Forward List ==============
    55curr->  http://127.0.0.1:8000/navigation/onload-navigation-iframe.html  **nav target**
    6             about:blank? (in frame "myFrame")
     6            http://127.0.0.1:8000/navigation/resources/blank.txt? (in frame "myFrame")
    77===============================================

  • trunk/LayoutTests/http/tests/navigation/onload-navigation-iframe-timeout-expected.txt

    r25410 r51070  
    66            about:blank (in frame "myFrame")
    77curr->  http://127.0.0.1:8000/navigation/onload-navigation-iframe-timeout.html
    8             about:blank? (in frame "myFrame")  **nav target**
     8            http://127.0.0.1:8000/navigation/resources/blank.txt? (in frame "myFrame")  **nav target**
    99===============================================

  • trunk/LayoutTests/http/tests/navigation/onload-navigation-iframe-timeout.html

    r42082 r51070  
    3939</head>
    4040<body onload="runTest()">
    41 <form id="myForm" target="myFrame" action="about:blank" method="get">
     41<form id="myForm" target="myFrame" action="resources/blank.txt" method="get">
    4242</form>
    4343In this case, Safari and Firefox adds a history item but IE doesn't.

  • trunk/LayoutTests/http/tests/navigation/onload-navigation-iframe.html

    r42082 r51070  
    3636</head>
    3737<body onload="runTest();">
    38 <form id="myForm" target="myFrame" action="about:blank" method="get">
     38<form id="myForm" target="myFrame" action="resources/blank.txt" method="get">
    3939</form>
    4040In this case, Safari and Firefox don't add a history item.
Note: See TracChangeset for help on using the changeset viewer.