Changeset 51093 in webkit
- Timestamp:
- Nov 17, 2009 3:37:59 PM (14 years ago)
- Location:
- trunk/WebKit/win
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKit/win/ChangeLog
r51092 r51093 1 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com> 2 3 DOMHTMLOptionElement is missing some functionality. 4 5 https://bugs.webkit.org/show_bug.cgi?id=31491 6 7 Reviewed by Dan Bernstein. 8 9 * DOMHTMLClasses.cpp: 10 (DOMHTMLOptionElement::text): 11 Cast m_element to an HTMLOptionElement, and call its text() function. 12 (DOMHTMLOptionElement::label): 13 Ditto, for label(). 14 1 15 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com> 2 16 -
trunk/WebKit/win/DOMHTMLClasses.cpp
r51092 r51093 853 853 854 854 HRESULT STDMETHODCALLTYPE DOMHTMLOptionElement::text( 855 /* [retval][out] */ BSTR* /*result*/) 856 { 857 ASSERT_NOT_REACHED(); 858 return E_NOTIMPL; 855 /* [retval][out] */ BSTR* result) 856 { 857 if (!result) 858 return E_POINTER; 859 860 *result = 0; 861 862 ASSERT(m_element); 863 ASSERT(m_element->hasTagName(optionTag)); 864 HTMLOptionElement* optionElement = static_cast<HTMLOptionElement*>(m_element); 865 866 *result = BString(optionElement->text()).release(); 867 return S_OK; 859 868 } 860 869 … … 881 890 882 891 HRESULT STDMETHODCALLTYPE DOMHTMLOptionElement::label( 883 /* [retval][out] */ BSTR* /*result*/) 884 { 885 ASSERT_NOT_REACHED(); 886 return E_NOTIMPL; 892 /* [retval][out] */ BSTR* result) 893 { 894 if (!result) 895 return E_POINTER; 896 897 *result = 0; 898 899 ASSERT(m_element); 900 ASSERT(m_element->hasTagName(optionTag)); 901 HTMLOptionElement* optionElement = static_cast<HTMLOptionElement*>(m_element); 902 903 *result = BString(optionElement->label()).release(); 904 return S_OK; 887 905 } 888 906
Note: See TracChangeset
for help on using the changeset viewer.