Changeset 51093 in webkit


Ignore:
Timestamp:
Nov 17, 2009 3:37:59 PM (14 years ago)
Author:
jhoneycutt@apple.com
Message:

DOMHTMLOptionElement is missing some functionality.

https://bugs.webkit.org/show_bug.cgi?id=31491

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp:

(DOMHTMLOptionElement::text):
Cast m_element to an HTMLOptionElement, and call its text() function.
(DOMHTMLOptionElement::label):
Ditto, for label().

Location:
trunk/WebKit/win
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/win/ChangeLog

    r51092 r51093  
     12009-11-12  Jon Honeycutt  <jhoneycutt@apple.com>
     2
     3        DOMHTMLOptionElement is missing some functionality.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=31491
     6
     7        Reviewed by Dan Bernstein.
     8
     9        * DOMHTMLClasses.cpp:
     10        (DOMHTMLOptionElement::text):
     11        Cast m_element to an HTMLOptionElement, and call its text() function.
     12        (DOMHTMLOptionElement::label):
     13        Ditto, for label().
     14
    1152009-11-12  Jon Honeycutt  <jhoneycutt@apple.com>
    216
  • trunk/WebKit/win/DOMHTMLClasses.cpp

    r51092 r51093  
    853853   
    854854HRESULT STDMETHODCALLTYPE DOMHTMLOptionElement::text(
    855         /* [retval][out] */ BSTR* /*result*/)
    856 {
    857     ASSERT_NOT_REACHED();
    858     return E_NOTIMPL;
     855        /* [retval][out] */ BSTR* result)
     856{
     857    if (!result)
     858        return E_POINTER;
     859
     860    *result = 0;
     861
     862    ASSERT(m_element);
     863    ASSERT(m_element->hasTagName(optionTag));
     864    HTMLOptionElement* optionElement = static_cast<HTMLOptionElement*>(m_element);
     865
     866    *result = BString(optionElement->text()).release();
     867    return S_OK;
    859868}
    860869   
     
    881890   
    882891HRESULT STDMETHODCALLTYPE DOMHTMLOptionElement::label(
    883         /* [retval][out] */ BSTR* /*result*/)
    884 {
    885     ASSERT_NOT_REACHED();
    886     return E_NOTIMPL;
     892        /* [retval][out] */ BSTR* result)
     893{
     894    if (!result)
     895        return E_POINTER;
     896
     897    *result = 0;
     898
     899    ASSERT(m_element);
     900    ASSERT(m_element->hasTagName(optionTag));
     901    HTMLOptionElement* optionElement = static_cast<HTMLOptionElement*>(m_element);
     902
     903    *result = BString(optionElement->label()).release();
     904    return S_OK;
    887905}
    888906   
Note: See TracChangeset for help on using the changeset viewer.