Changeset 51105 in webkit


Ignore:
Timestamp:
Nov 18, 2009 4:53:22 AM (14 years ago)
Author:
Girish Ramakrishnan
Message:

[Qt] Mac Plugins: Remove null timer

Reviewed by Tor Arne Vestbø.

A null timer was used to send mouse move events. Instead, we now use
move events to send nullEvent. This brings down CPU usage by 20-30%.

​https://bugs.webkit.org/show_bug.cgi?id=31624

Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r51103 r51105  
     12009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
     2
     3        Reviewed by Tor Arne VestbÃ.,
     4
     5        [Qt] Mac Plugins: Remove null timer
     6       
     7        A null timer was used to send mouse move events. Instead, we now use
     8        move events to send nullEvent. This brings down CPU usage by 20-30%.
     9       
     10        https://bugs.webkit.org/show_bug.cgi?id=31624
     11
     12        * plugins/PluginView.h:
     13        * plugins/mac/PluginViewMac.cpp:
     14        (WebCore::PluginView::platformStart):
     15        (WebCore::PluginView::handleMouseEvent):
     16
    1172009-11-18  Benjamin Poulain  <benjamin.poulain@nokia.com>
    218
    … …  
    856872            Count keys in the quota.
    857873
    858 2009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
     8742009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
    859875
    860876        Reviewed by Eric Seidel.
    … …  
    24832499        (WebCore::PluginView::PluginView):
    24842500
    2485 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
     25012009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
    24862502
    24872503        Rubber-stamped by Kenneth Rohde Christiansen.
    … …  
    249425102009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
    24952511
    2496         Reviewed by Tor Arne Vestbø.
     2512        Reviewed by Tor Arne Vestbø.
    24972513
    24982514        Introduce a function for querying the input method status
    … …  
    28372853        * bindings/js/ScriptController.h:
    28382854
    2839 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
     28552009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
    28402856
    28412857        [Qt] Unreviewed buildfix after r50760.
    … …  
    539454102009-11-04  Yael Aharon  <yael.aharon@nokia.com>
    53955411
    5396         Reviewed by Tor Arne Vestbø.
     5412        Reviewed by Tor Arne Vestbø.
    53975413
    53985414        [Qt] ASSERT failure when receiving 401 HTTP Authentication response.
    … …  
    54135429        * WebCore.base.exp: Sorted.
    54145430
    5415 2009-11-04  Csaba Osztrogonác  <ossy@webkit.org>
     54312009-11-04  Csaba Osztrogonác  <ossy@webkit.org>
    54165432
    54175433        Unreviewed rollout.
    … …  
    54695485        (webkit_accessible_get_parent):
    54705486
    5471 2009-11-04  Dominik Röttsches  <dominik.roettsches@access-company.com>
     54872009-11-04  Dominik Röttsches  <dominik.roettsches@access-company.com>
    54725488
    54735489        Reviewed by Eric Seidel.
    … …  
    54765492        [GTK] Implement Unicode functionality using GLib
    54775493
    5478         Initial version of this patch by Jürg Billeter and Naiem Shaik.
     5494        Initial version of this patch by Jürg Billeter and Naiem Shaik.
    54795495        Patch 2/4 - Moving TextCodecs to GLib
    54805496       
    … …  
    58995915            <rdar://problem/6937089>.
    59005916        (WebCore::RenderWidget::setWidgetGeometry): Assert that widget updates
    5901             are not suspended, because this function updates the widget’s
     5917            are not suspended, because this function updates the widget’s
    59025918            bounds, which can result in arbitrary native and JavaScript code
    59035919            execution. I think this assertion is true thanks to some deferred-
    … …  
    612661422009-11-03  Simon Hausmann  <hausmann@webkit.org>
    61276143
    6128         Reviewed by Tor Arne Vestbø.
     6144        Reviewed by Tor Arne Vestbø.
    61296145
    61306146        Make QWebPluginDatabase private API for now.
    … …  
    613661522009-11-03  Simon Hausmann  <hausmann@webkit.org>
    61376153
    6138         Reviewed by Tor Arne Vestbø.
     6154        Reviewed by Tor Arne Vestbø.
    61396155
    61406156        Extended the conversion of the WebCore ResourceRequest to the
    … …  
    61626178        (InjectedScript._ensureCommandLineAPIInstalled):
    61636179
    6164 2009-11-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     61802009-11-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    61656181
    61666182        Rubber-stamped by Antti Koivisto.
    … …  
    669167072009-11-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
    66926708
    6693         Reviewed by Tor Arne Vestbø.
     6709        Reviewed by Tor Arne Vestbø.
    66946710
    66956711        [Qt] Fix Qt build on Windows.
    … …  
    75577573        (WebCore::counterValueForElement):
    75587574
    7559 2009-10-30  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
     75752009-10-30  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
    75607576
    75617577        Reviewed by Gustavo Noronha.
    … …  
    78607876        m_characterInCurrentGlyph.
    78617877        (WebCore::ComplexTextController::offsetForPosition): If the hit glyph spans multiple
    7862         characters, compute the hit character based on dividing the glyph’s total advance into
     7878        characters, compute the hit character based on dividing the glyph’s total advance into
    78637879        a number of equal intervals equal to the number of characters and assigning the hit to the
    78647880        character corresponding to the hit interval.
    78657881        (WebCore::ComplexTextController::advance): If the final offset occurs mid-glyph, advance
    7866         by a fraction of the glyph’s total advance.
     7882        by a fraction of the glyph’s total advance.
    78677883        * platform/graphics/mac/ComplexTextController.h: Added m_characterInCurrentGlyph.
    78687884
    … …  
    794379592009-10-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
    79447960
    7945         Reviewed by Tor Arne Vestbø.
     7961        Reviewed by Tor Arne Vestbø.
    79467962
    79477963        [Qt] Implement DELETE HTTP method for XmlHttpRequest
    … …  
    80008016        (WebCore::Database::Database):
    80018017
    8002 2009-10-29  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
     80182009-10-29  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
    80038019
    80048020        Reviewed by Gustavo Noronha.
    … …  
    82568272        parts of the ComplexTextController implementation.
    82578273        (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI
    8258         callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked
     8274        callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked
    82598275        when the ComplexTextRun constructor calls ATSUGetGlyphBounds().
    82608276        (WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm.
    … …  
    865586712009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
    86568672
    8657         Reviewed by Tor Arne Vestbø.
     8673        Reviewed by Tor Arne Vestbø.
    86588674
    86598675        [Qt] QWebHistory::saveState() is inconsistent with the Qt API
    … …  
    942294382009-10-27  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
    94239439
    9424         Reviewed by Tor Arne Vestbø.
     9440        Reviewed by Tor Arne Vestbø.
    94259441
    94269442        [Qt] Fix assertion crashes introduced by changes made in r50110.
    … …  
    94599475        (GetAtkInterfaceTypeFromWAIType):
    94609476
    9461 2009-10-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     94772009-10-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    94629478
    94639479        Reviewed by Lars Knoll.
    … …  
    96599675        handles the case of displaying multiple preview dialogs nicely.
    96609676       
    9661         All credit to Samuel Rødal for suggesting usage of QPixmap::copy().
     9677        All credit to Samuel Rødal for suggesting usage of QPixmap::copy().
    96629678       
    96639679        https://bugs.webkit.org/show_bug.cgi?id=30714
    … …  
    11110111262009-10-23  Janne Koskinen  <janne.p.koskinen@digia.com>
    1111111127
    11112         Reviewed by Tor Arne Vestbø.
     11128        Reviewed by Tor Arne Vestbø.
    1111311129
    1111411130        [Qt] don't undef NULL in Symbian emulator
    … …  
    11123111392009-10-23  Janne Koskinen  <janne.p.koskinen@digia.com>
    1112411140
    11125         Reviewed by Tor Arne Vestbø.
     11141        Reviewed by Tor Arne Vestbø.
    1112611142
    1112711143        [Qt] Correct linking of sqlite3 for Symbian
    … …  
    1204012056        (WebCore::CSSParser::parseFillShorthand): Use parseBackgroundClip() to
    1204112057        reparse the value. The old code called parseFillProperty() again, which
    12042         didn’t work, because parseFillProperty() advances the value list.
     12058        didn’t work, because parseFillProperty() advances the value list.
    1204312059        (WebCore::CSSParser::parseFillProperty): Changed to use
    1204412060        parseBackgroundClip().
    … …  
    1299613012        (WebCore::Frame::~Frame): Right after frame disconnects from DOMWindow, clear WindowShell.
    1299713013
    12998 2009-10-19  Csaba Osztrogonác  <ossy@webkit.org>
     130142009-10-19  Csaba Osztrogonác  <ossy@webkit.org>
    1299913015
    1300013016        Unreviewed build warning fix.
    … …  
    13063130792009-10-19  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
    1306413080
    13065         Reviewed by Tor Arne Vestbø.
     13081        Reviewed by Tor Arne Vestbø.
    1306613082
    1306713083        [Qt] Fix build on Windows.
    … …  
    1385813874        (WebCore::MIMETypeRegistry::getMIMETypeForPath):
    1385913875
    13860 2009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     138762009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    1386113877
    1386213878        Pull out r49676 as it caused build breakges on Symbian
    … …  
    1386413880        * plugins/symbian/PluginViewSymbian.cpp:
    1386513881
    13866 2009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     138822009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    1386713883
    1386813884        Reviewed by Ariya Hidayat.
    … …  
    13973139892009-10-16  Yael Aharon  <yael.aharon@nokia.com>
    1397413990
    13975         Reviewed by Tor Arne Vestbø.
     13991        Reviewed by Tor Arne Vestbø.
    1397613992
    1397713993        [Qt] Need a way to inform the application when a Netscape plugin is created or deleted
    … …  
    1399814014        (WebCore::defaultLanguage):
    1399914015
    14000 2009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     140162009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    1400114017
    1400214018        Reviewed by Ariya Hidayat.
    … …  
    1442214438        (WebCore::MediaPlayerPrivate::cancelLoad):
    1442314439
    14424 2009-10-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
     144402009-10-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
    1442514441
    1442614442        Reviewed by Gustavo Noronha.
    … …  
    1444114457        Fix race condition in unlock/render that would lead to deadlocks.
    1444214458
    14443 2009-10-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
     144592009-10-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
    1444414460
    1444514461        Reviewed by Gustavo Noronha.
    … …  
    1582215838        (WebCore::GraphicsContext3D::readPixels):
    1582315839
    15824 2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
     158402009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
    1582515841
    1582615842        Reviewed by Gustavo Noronha.
    … …  
    1585815874        * svg/graphics/filters/SVGFEFlood.h:
    1585915875
    15860 2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
     158762009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
    1586115877
    1586215878        Reviewed by Gustavo Noronha.
    … …  
    1587215888        the aspect ratio and center it.
    1587315889
    15874 2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
     158902009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
    1587515891
    1587615892        Reviewed by Gustavo Noronha.
    … …  
    1596315979        (WebCore::FrameLoader::checkIfRunInsecureContent):
    1596415980
    15965 2009-10-11  Søren Gjesse  <sgjesse@chromium.org>
     159812009-10-11  Søren Gjesse  <sgjesse@chromium.org>
    1596615982
    1596715983        Reviewed by Adam Barth.
    … …  
    18396184122009-10-06  Simon Hausmann  <simon.hausmann@nokia.com>
    1839718413
    18398         Reviewed by Tor Arne Vestbø.
     18414        Reviewed by Tor Arne Vestbø.
    1839918415
    1840018416        Fix the Qt/Windows build by stubbing out the still image
    … …  
    1859118607        (webkit_video_sink_idle_func):
    1859218608
    18593 2009-10-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     186092009-10-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    1859418610
    1859518611        Reviewed by Simon Hausmann.
    … …  
    19459194752009-10-05  Jakub Wieczorek  <faw217@gmail.com>
    1946019476
    19461         Reviewed by Tor Arne Vestbø.
     19477        Reviewed by Tor Arne Vestbø.
    1946219478
    1946319479        [Qt] windowsKeyCodeForKeyEvent() returns a wrong value for the F10 key.
    … …  
    1953119547        (WebInspector.WatchExpressionsSection.prototype.update):
    1953219548
    19533 2009-10-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     195492009-10-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    1953419550
    1953519551        Reviewed by Eric Carlson.
    … …  
    1954519561        (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
    1954619562
    19547 2009-10-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     195632009-10-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    1954819564
    1954919565        Reviewed by Eric Carlson.
    … …  
    19895199112009-10-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
    1989619912
    19897         Reviewed by Tor Arne Vestbø.
     19913        Reviewed by Tor Arne Vestbø.
    1989819914
    1989919915        [Qt] Add NPNVToolkit value quirk in plugins for nspluginwrapper.
    … …  
    19907199232009-10-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
    1990819924
    19909         Reviewed by Tor Arne Vestbø.
     19925        Reviewed by Tor Arne Vestbø.
    1991019926
    1991119927        [Qt] X sync our XEmbed container window creation before sending the
    … …  
    20971209872009-10-01  Alexis Menard  <alexis.menard@nokia.com>
    2097220988
    20973         Reviewed by Tor Arne Vestbø.
     20989        Reviewed by Tor Arne Vestbø.
    2097420990
    2097520991        Rename QWebGraphicsItem to QGraphicsWebView
    … …  
    22030220462009-09-29  Simon Hausmann  <simon.hausmann@nokia.com>
    2203122047
    22032         Reviewed by Tor Arne Vestbø.
     22048        Reviewed by Tor Arne Vestbø.
    2203322049
    2203422050        Make the XSLT conditional in DOMWindow.idl's xsltProcessor
    … …  
    22040220562009-09-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
    2204122057
    22042         Reviewed by Simon Hausmann and Tor Arne Vestbø.
     22058        Reviewed by Simon Hausmann and Tor Arne Vestbø.
    2204322059
    2204422060        Use the ResourceError as it is supposed to and handle
    … …  
    24572245882009-09-23  Simon Hausmann  <simon.hausmann@nokia.com>
    2457324589
    24574         Reviewed by Tor Arne Vestbø.
     24590        Reviewed by Tor Arne Vestbø.
    2457524591
    2457624592        Fix the Qt/Windows build, after the introduction of
    … …  
    2498925005        (WebCore::V8Custom::WindowSetTimeoutImpl):
    2499025006
    24991 2009-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     250072009-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    2499225008
    2499325009        Reviewed by Simon Hausmann.
    … …  
    2499725013        * plugins/mac/PluginViewMac.cpp:
    2499825014
    24999 2009-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     250152009-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    2500025016
    2500125017        Reivewed by Simon Hausmann.
    … …  
    2621026226
    2621126227        <rdar://problem/7007541>
    26212         CrashTracer: 4800crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...
     26228        CrashTracer: 4800crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...
    2621326229       
    2621426230        Make RuntimeObjectImp more robust against m_instance being a null (which can happen if an OOP plug-in
    … …  
    27342273582009-09-15  Alex Milowski  <alex@milowski.com>
    2734327359
    27344         Reviewed by Tor Arne Vestbø.
     27360        Reviewed by Tor Arne Vestbø.
    2734527361
    2734627362        Added ENABLE_MATHML to feature defines
    … …  
    27849278652009-09-14  Yael Aharon  <yael.aharon@nokia.com>
    2785027866
    27851         Reviewed by Tor Arne Vestbø.
     27867        Reviewed by Tor Arne Vestbø.
    2785227868
    2785327869        [Qt] Assert hit when dropping a file in QtLauncher
    … …  
    29874298902009-09-08  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
    2987529891
    29876         Reviewed by Tor Arne Vestbø.
     29892        Reviewed by Tor Arne Vestbø.
    2987729893
    2987829894        [Qt] Buildfix. Build error caused by r48150.
    … …  
    30376303922009-09-07  Chris Hills <chaz@chaz6.com>
    3037730393
    30378         Reviewed by Tor Arne Vestbø.
     30394        Reviewed by Tor Arne Vestbø.
    3037930395
    3038030396        [Qt] Use direct includes for Phonon, not the pretty ones
    … …  
    3217332189        * platform/graphics/wince/ImageBufferWince.cpp: Added.
    3217432190
    32175 2009-08-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     321912009-08-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    3217632192
    3217732193        Reviewed by Eric Seidel.
    … …  
    3219232208        * plugins/win/PluginViewWin.cpp:
    3219332209
    32194 2009-08-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     322102009-08-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    3219532211
    3219632212        Reviewed by Eric Seidel.
    … …  
    3313133147        (WebInspector.pausedScript):
    3313233148
    33133 2009-08-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     331492009-08-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    3313433150
    3313533151        Reviewed by Ariya Hidayat.
    … …  
    3342333439        (WebCore::ScrollView::setScrollbarModes):
    3342433440
    33425 2009-08-28  Cédric Luthi <cedric.luthi@gmail.com>
    33426 
    33427         Reviewed by Tor Arne Vestbø
     334412009-08-28  Cédric Luthi <cedric.luthi@gmail.com>
     33442
     33443        Reviewed by Tor Arne Vestbø
    3342833444
    3342933445        [Qt/Mac] Un-blacklist the QuickTime plugin
    … …  
    34093341092009-08-27  Ariya Hidayat  <ariya.hidayat@nokia.com>
    3409434110
    34095         Reviewed by Tor Arne Vestbø.
     34111        Reviewed by Tor Arne Vestbø.
    3409634112
    3409734113        [Qt] Build fix, missing functions after r47763.
    … …  
    3416934185        <rdar://problem/7172437>
    3417034186
    34171         A media element triggers the resource selection algorithm if 
     34187        A media element triggers the resource selection algorithm if 
    3417234188        play() is called when the networkState attribute is NETWORK_EMPTY, but
    3417334189        it also immediately queues 'play' and either 'waiting' or 'playing' events.
    34174         One of the steps in preparing to load is to flush pending events, so those 
     34190        One of the steps in preparing to load is to flush pending events, so those 
    3417534191        events were lost if the load timer fired quickly enough. Fixed by deleting
    3417634192        pending events before scheduling the load timer.
    … …  
    3426834284        * rendering/RenderInline.cpp:
    3426934285        (WebCore::RenderInline::linesVisibleOverflowBoundingBox): Added. Returns
    34270             the bounding box of all lines’ visible overflow boxes (under the
     34286            the bounding box of all lines’ visible overflow boxes (under the
    3427134287            assumption that the first and last lines determine the top and
    3427234288            bottom, respectively).
    … …  
    3492834944        (WebCore::): Constants for volume control parts.
    3492934945
    34930 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     349462009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    3493134947
    3493234948        Reviewed by Ariya Hidayat.
    … …  
    4143741453
    4143841454        <rdar://problem/6952336>
    41439         CrashTracer: [USER] 3 crashes in Safari at com.apple.WebCore • WebCore::SecurityOrigin::canAccess const 27
     41455        CrashTracer: [USER] 3 crashes in Safari at com.apple.WebCore • WebCore::SecurityOrigin::canAccess const 27
    4144041456
    4144141457        Make sure to set the security origin before calling dispatchWindowObjectAvailable.
    … …  
    44065440812009-08-07  Simon Hausmann  <simon.hausmann@nokia.com>
    4406644082
    44067         Reviewed by Tor Arne Vestbø.
     44083        Reviewed by Tor Arne Vestbø.
    4406844084
    4406944085        Back out r46847 and fix the Qt build system to always generate
    … …  
    4606546081        (WebCore::JSNode::removeEventListener):
    4606646082
    46067 2009-08-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     460832009-08-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    4606846084
    4606946085        Reviewed by Anders Carlsson.
    … …  
    4608746103        * plugins/win/PluginViewWin.cpp:
    4608846104
    46089 2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     461052009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    4609046106
    4609146107        Reviewed by Anders Carlsson.
    … …  
    4610246118        (WebCore::PluginView::start):
    4610346119
    46104 2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     461202009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    4610546121
    4610646122        Reviewed by Anders Carlsson.
    … …  
    4840848424        (WebCore::PopupMenu::populate):
    4840948425
    48410 2009-07-28  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     484262009-07-28  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    4841148427
    4841248428        Reviewed by Steve Falkenburg.
    … …  
    48459484752009-07-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
    4846048476
    48461         Reviewed by Tor Arne Vestbø
     48477        Reviewed by Tor Arne Vestbø
    4846248478
    4846348479        Make equality checks for logging channel names ignore casing.
    … …  
    4934249358        * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
    4934349359
    49344 2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     493602009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    4934549361
    4934649362        Reviewed by Simon Hausmann.
    … …  
    4935049366        * plugins/mac/PluginViewMac.cpp:
    4935149367
    49352 2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     493682009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    4935349369
    4935449370        Reviewed by Jan Michael Alonzo.
    … …  
    5069950715
    5070050716        * css/CSSComputedStyleDeclaration.cpp:
    50701         (WebCore::valueForShadow): Set the ShadowValue’s shadow style to 'inset'
     50717        (WebCore::valueForShadow): Set the ShadowValue’s shadow style to 'inset'
    5070250718            as needed.
    5070350719
    … …  
    52069520852009-07-21  Albert Astals Cid <aacid@kde.org>
    5207052086
    52071         Reviewed by Tor Arne Vestbø.
     52087        Reviewed by Tor Arne Vestbø.
    5207252088
    5207352089        Change #error line not to have a ' (single quote)
    … …  
    52522525382009-07-20  Simon Hausmann  <simon.hausmann@nokia.com>
    5252352539
    52524         Reviewed by and done with Tor Arne Vestbø.
     52540        Reviewed by and done with Tor Arne Vestbø.
    5252552541
    5252652542        Fix fast/css/pseudo-required-optional-*.html in the Qt build
    … …  
    52541525572009-07-20  Simon Hausmann  <simon.hausmann@nokia.com>
    5254252558
    52543         Rubber-stamped by Tor Arne Vestbø.
     52559        Rubber-stamped by Tor Arne Vestbø.
    5254452560
    5254552561        Add missing (sorted) header files to the HEADERS variable in the qmake
    … …  
    5337153387        (WebCore::PluginDatabase::setPluginDirectories): Make public
    5337253388
    53373 2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     533892009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    5337453390
    5337553391        Reviewed by Simon Hausmann.
    … …  
    5338153397        * plugins/mac/PluginViewMac.cpp:
    5338253398
    53383 2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     533992009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    5338453400
    5338553401        Reviewed by Simon Hausmann.
    … …  
    5339853414        * plugins/mac/PluginViewMac.cpp:
    5339953415
    53400 2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     534162009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    5340153417
    5340253418        Reviewed by Simon Hausmann.
    … …  
    5341053426        * plugins/PluginView.cpp:
    5341153427
    53412 2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     534282009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    5341353429
    5341453430        Reviewed by Simon Hausmann.
    … …  
    5342253438        * plugins/win/PluginViewWin.cpp: Add debug for getValue
    5342353439
    53424 2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     534402009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    5342553441
    5342653442        Reviewed by Holger Freyther.
    … …  
    5343053446        * plugins/PluginDebug.cpp: Use license from PluginDebug.h
    5343153447
    53432 2009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     534482009-07-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    5343353449
    5343453450        Reviewed by Simon Hausmann.
    … …  
    5446154477        * bindings/js/JSXSLTProcessorConstructor.h:
    5446254478
    54463 2009-07-15  Kai Br�ning  <kai@granus.net>
     544792009-07-15  Kai Br�ning  <kai@granus.net>
    5446454480
    5446554481        Reviewed by Dave Hyatt.
    … …  
    5574155757        * GNUmakefile.am:
    5574255758
    55743 2009-07-13  Cédric Luthi  <cedric.luthi@gmail.com>
    55744 
    55745         Reviewed by Tor Arne Vestbø.
     557592009-07-13  Cédric Luthi  <cedric.luthi@gmail.com>
     55760
     55761        Reviewed by Tor Arne Vestbø.
    5574655762
    5574755763        Fix NPWindow clip rect in PluginViewMac
    … …  
    5890958925        Reviewed by Darin Adler.
    5891058926
    58911         <rdar://problem/7008093> Media controller can’t be used to scrub when movie is
    58912         narrow — track is too narrow
     58927        <rdar://problem/7008093> Media controller can’t be used to scrub when movie is
     58928        narrow — track is too narrow
    5891358929
    5891458930        Do not show media controller time display elements when the a movie is too narrow.
    … …  
    62918629342009-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
    6291962935
    62920         Reviewed by and done with Tor Arne Vestbø.
     62936        Reviewed by and done with Tor Arne Vestbø.
    6292162937
    6292262938        Fix shortcut keyboard handling with plugins on the Qt/Mac build.
    … …  
    63593636092009-06-24  Simon Hausmann  <simon.hausmann@nokia.com>
    6359463610
    63595         Reviewed by Tor Arne Vestbø.
     63611        Reviewed by Tor Arne Vestbø.
    6359663612
    6359763613        Fix the build without ENABLE_VIDEO.
    … …  
    6415264168        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
    6415364169
    64154 2009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     641702009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    6415564171
    6415664172        Reviewed by Simon Hausmann.
    … …  
    6416364179        * platform/qt/LoggingQt.cpp:
    6416464180
    64165 2009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     641812009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    6416664182
    6416764183        Reviewed by Simon Hausmann.
    … …  
    6418464200        * plugins/qt/PluginPackageQt.cpp:
    6418564201
    64186 2009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     642022009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    6418764203
    6418864204        Reviewed by Simon Hausmann.
    … …  
    6420864224        (WebCore::PluginView::globalMousePosForPlugin):
    6420964225
    64210 2009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     642262009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    6421164227
    6421264228        Rubber-stamped by Simon Hausmann.
    … …  
    6480364819        (WebCore::QNetworkReplyHandler::):
    6480464820
    64805 2009-06-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
     648212009-06-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    6480664822
    6480764823        Fix the Qt build.
    … …  
    6685566871        Reviewed by Brady Eidson.
    6685666872
    66857         <rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient 53
     66873        <rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient 53
    6685866874       
    6685966875        When revalidating a resource, calling addClient() on one client might cause another to get removed.

  • trunk/WebCore/plugins/PluginView.h

    r49933 r51105  
    325325#elif defined(XP_MACOSX)
    326326        NP_CGContext m_npCgContext;
    327         OwnPtr<Timer<PluginView> > m_nullEventTimer;
    328327        NPDrawingModel m_drawingModel;
    329328        NPEventModel m_eventModel;
    330329
    331330        void setNPWindowIfNeeded();
    332         void nullEventTimerFired(Timer<PluginView>*);
    333331        Point globalMousePosForPlugin() const;
    334332#endif

  • trunk/WebCore/plugins/mac/PluginViewMac.cpp

    r49620 r51105  
    183183    show();
    184184
    185     // TODO: Implement null timer throttling depending on plugin activation
    186     m_nullEventTimer.set(new Timer<PluginView>(this, &PluginView::nullEventTimerFired));
    187     m_nullEventTimer->startRepeating(0.02);
    188 
    189185    return true;
    190186}
    … …  
    485481
    486482    if (event->type() == eventNames().mousemoveEvent) {
    487         // Mouse movement is handled by null timer events
    488         return;
     483        record.what = nullEvent;
    489484    } else if (event->type() == eventNames().mouseoverEvent) {
    490485        record.what = adjustCursorEvent;
    … …  
    593588}
    594589
    595 void PluginView::nullEventTimerFired(Timer<PluginView>*)
    596 {
    597     EventRecord record;
    598 
    599     record.what = nullEvent;
    600     record.message = 0;
    601     record.when = TickCount();
    602     record.where = globalMousePosForPlugin();
    603     record.modifiers = GetCurrentKeyModifiers();
    604     if (!Button())
    605         record.modifiers |= btnState;
    606 
    607     if (!dispatchNPEvent(record))
    608         LOG(Events, "PluginView::nullEventTimerFired(): Null event not accepted");
    609 }
    610 
    611590static int modifiersForEvent(UIEventWithKeyState* event)
    612591{
Note: See TracChangeset for help on using the changeset viewer.