Changeset 51115 in webkit

Timestamp:

Nov 18, 2009 9:25:42 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2009-11-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clone timeline records array instead of
copying reference on invalidate all.

​https://bugs.webkit.org/show_bug.cgi?id=31596

• inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):

Location:

trunk

Files:

• LayoutTests/platform/win/Skipped (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/front-end/AbstractTimelinePanel.js (modified) (1 diff)

trunk/LayoutTests/platform/win/Skipped

@@ -704 +704 @@
 # https://bugs.webkit.org/show_bug.cgi?id=31479
 websocket
-
-# https://bugs.webkit.org/show_bug.cgi?id=31596
-# Inspector timeline tests are flaky on Windows Release, skipping for now
-inspector/timeline-layout.html
-inspector/timeline-mark-timeline.html
-inspector/timeline-parse-html.html
-inspector/timeline-recalculate-styles.html
-inspector/timeline-script-tag-1.html
-inspector/timeline-script-tag-2.html

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Web Inspector: clone timeline records array instead of
+        copying reference on invalidate all.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31596
+
+        * inspector/front-end/AbstractTimelinePanel.js:
+        (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
+
 2009-11-18  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/inspector/front-end/AbstractTimelinePanel.js

@@ -270 +270 @@
     invalidateAllItems: function()
     {
-        this._staleItems = this._items;
+        this._staleItems = this._items.slice();
     },