Changeset 51118 in webkit

Timestamp:

Nov 18, 2009 9:57:10 AM (14 years ago)

Author:

benm@google.com

Message:

HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
​https://bugs.webkit.org/show_bug.cgi?id=31593

Reviewed by Darin Adler.

WebCore:

Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.

LayoutTests:

• fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-whitespace.js: Added.
• fast/dom/HTMLAnchorElement/set-href-attribute-whitespace-expected.txt: Added.
• fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-whitespace.js (added)
• LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-whitespace-expected.txt (added)
• LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLAnchorElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-11-18  Ben Murdoch  <benm@google.com>
+
+        Reviewed by Darin Adler.
+
+        HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
+        https://bugs.webkit.org/show_bug.cgi?id=31593
+
+        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-whitespace.js: Added.
+        * fast/dom/HTMLAnchorElement/set-href-attribute-whitespace-expected.txt: Added.
+        * fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html: Added.
+
 2009-11-18  Alexey Proskuryakov  <ap@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-18  Ben Murdoch  <benm@google.com>
+
+        Reviewed by Darin Adler.
+
+        HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
+        https://bugs.webkit.org/show_bug.cgi?id=31593
+
+        Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
+
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
+
 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/html/HTMLAnchorElement.cpp

@@ -328 +328 @@
 KURL HTMLAnchorElement::href() const
 {
-    return document()->completeURL(getAttribute(hrefAttr));
+    return document()->completeURL(deprecatedParseURL(getAttribute(hrefAttr)));
 }