Changeset 51121 in webkit


Ignore:
Timestamp:
Nov 18, 2009 10:26:51 AM (14 years ago)
Author:
pfeldman@chromium.org
Message:

2009-11-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Get rid of metrics and properties sidebars'
flickering.

​https://bugs.webkit.org/show_bug.cgi?id=31629

  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/PropertiesSidebarPane.js:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r51119 r51121  
     12009-11-18  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: Get rid of metrics and properties sidebars'
     6        flickering.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=31629
     9
     10        * inspector/front-end/MetricsSidebarPane.js:
     11        * inspector/front-end/PropertiesSidebarPane.js:
     12
    1132009-11-17  Brian Weinstein  <bweinstein@apple.com>
    214

  • trunk/WebCore/inspector/front-end/MetricsSidebarPane.js

    r48046 r51121  
    3636    update: function(node)
    3737    {
    38         var body = this.bodyElement;
    39 
    40         body.removeChildren();
    41 
    4238        if (node)
    4339            this.node = node;
    … …  
    4541            node = this.node;
    4642
    47         if (!node || !node.ownerDocument.defaultView)
     43        if (!node || !node.ownerDocument.defaultView || node.nodeType !== Node.ELEMENT_NODE) {
     44            this.bodyElement.removeChildren();
    4845            return;
    49 
    50         if (node.nodeType !== Node.ELEMENT_NODE)
    51             return;
     46        }
    5247
    5348        var self = this;
    … …  
    5651                return;
    5752            var style = WebInspector.CSSStyleDeclaration.parseStyle(stylePayload);
    58             self._update(node, body, style);
     53            self._update(style);
    5954        };
    6055        InjectedScriptAccess.getComputedStyle(node.id, callback);
    … …  
    6863    },
    6964
    70     _update: function(node, body, style)
     65    _update: function(style)
    7166    {
    7267        var metricsElement = document.createElement("div");
    … …  
    170165
    171166        metricsElement.appendChild(previousBox);
    172         body.appendChild(metricsElement);
     167        this.bodyElement.removeChildren();
     168        this.bodyElement.appendChild(metricsElement);
    173169    },
    174170

  • trunk/WebCore/inspector/front-end/PropertiesSidebarPane.js

    r48046 r51121  
    3737        var body = this.bodyElement;
    3838
    39         body.removeChildren();
    40 
    41         this.sections = [];
    42 
    43         if (!node)
     39        if (!node) {
     40            body.removeChildren();
     41            this.sections = [];
    4442            return;
     43        }
    4544
    4645        var self = this;
Note: See TracChangeset for help on using the changeset viewer.