Changeset 51188 in webkit


Ignore:
Timestamp:
Nov 19, 2009 9:42:38 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

https://bugs.webkit.org/show_bug.cgi?id=31669

  • platform/gtk/Skipped:

2009-11-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

https://bugs.webkit.org/show_bug.cgi?id=31669

  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_show):
  • webkit/webkitwebinspector.h:

2009-11-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

https://bugs.webkit.org/show_bug.cgi?id=31669

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector):
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r51181 r51188  
     12009-11-19  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Gustavo Noronha Silva.
     4
     5        Web Inspector: Implement "show inspector" in WebKit GTK
     6        API and enable console tests.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=31669
     9
     10        * platform/gtk/Skipped:
     11
    1122009-11-19  Shinichiro Hamaji  <hamaji@chromium.org>
    213
  • trunk/LayoutTests/platform/gtk/Skipped

    r51074 r51188  
    56805680fast/history/back-forward-reset-after-error-handling.html
    56815681
    5682 # See https://bugs.webkit.org/show_bug.cgi?id=31472
    5683 inspector/console-dir.html
    5684 inspector/console-dirxml.html
    5685 inspector/console-format-collections.html
    5686 inspector/console-format.html
    5687 inspector/console-tests.html
  • trunk/WebKit/gtk/ChangeLog

    r51109 r51188  
     12009-11-19  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Gustavo Noronha Silva.
     4
     5        Web Inspector: Implement "show inspector" in WebKit GTK
     6        API and enable console tests.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=31669
     9
     10        * webkit/webkitwebinspector.cpp:
     11        (webkit_web_inspector_show):
     12        * webkit/webkitwebinspector.h:
     13
    1142009-11-18  Martin Robinson  <martin.james.robinson@gmail.com>
    215
  • trunk/WebKit/gtk/webkit/webkitwebinspector.cpp

    r51072 r51188  
    467467
    468468/**
     469 * webkit_web_inspector_show:
     470 * @web_inspector: the #WebKitWebInspector that will be shown
     471 *
     472 * Causes the Web Inspector to be shown.
     473 *
     474 * Since: 1.1.17
     475 */
     476void webkit_web_inspector_show(WebKitWebInspector* webInspector)
     477{
     478    g_return_if_fail(WEBKIT_IS_WEB_INSPECTOR(webInspector));
     479
     480    WebKitWebInspectorPrivate* priv = webInspector->priv;
     481
     482    Frame* frame = priv->page->focusController()->focusedOrMainFrame();
     483    FrameView* view = frame->view();
     484
     485    if (!view)
     486        return;
     487
     488    priv->page->inspectorController()->show();
     489}
     490
     491/**
    469492 * webkit_web_inspector_inspect_coordinates:
    470493 * @web_inspector: the #WebKitWebInspector that will do the inspection
  • trunk/WebKit/gtk/webkit/webkitwebinspector.h

    r50245 r51188  
    6565
    6666WEBKIT_API void
     67webkit_web_inspector_show(WebKitWebInspector* webInspector);
     68
     69WEBKIT_API void
    6770webkit_web_inspector_close(WebKitWebInspector* webInspector);
    68 
    6971G_END_DECLS
    7072
  • trunk/WebKitTools/ChangeLog

    r51187 r51188  
     12009-11-19  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Gustavo Noronha Silva.
     4
     5        Web Inspector: Implement "show inspector" in WebKit GTK
     6        API and enable console tests.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=31669
     9
     10        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     11        (LayoutTestController::showWebInspector):
     12
    1132009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
    214
  • trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r51072 r51188  
    505505
    506506    g_object_set(webSettings, "enable-developer-extras", TRUE, NULL);
    507     webkit_web_inspector_inspect_coordinates(inspector, 0, 0);
     507    webkit_web_inspector_show(inspector);
    508508}
    509509
Note: See TracChangeset for help on using the changeset viewer.